Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable windows for travis #4

Merged
merged 2 commits into from
Oct 16, 2018
Merged

Enable windows for travis #4

merged 2 commits into from
Oct 16, 2018

Conversation

cemremengu
Copy link
Contributor

Enable windows testing to verify that file generation is cross platform. Hopefully tests cover this though.

Enable windows testing
@cemremengu
Copy link
Contributor Author

@mcollina tests fail. Possible root cause for fastify-cli

@mcollina
Copy link
Owner

Would you like to amend this to fix them?

@cemremengu
Copy link
Contributor Author

Sure, will look into it.

Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 483bf30 into mcollina:master Oct 16, 2018
@cemremengu cemremengu deleted the patch-1 branch October 16, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants