-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.7 wip #42
Conversation
Changes Unknown when pulling 444754b on v0.7-wip into * on master*. |
Changes Unknown when pulling 6af24a3 on v0.7-wip into * on master*. |
Limit & Offset for get and search
@elf-pavlik, v0.7-wip is feature complete. It is a 'big' release. Could you please give it a spin and check if there are bugs? I would love to give some polish to JoinStream and SortJoinStream, but time is up and I think it's better to release this. |
congratulations for taking it to 0.7 👏 what do you think about adding deprecation warning to |
You are right. I need to add a deprecation warning. Should I just use |
I think console.warn() should do it for now! If we need something more sophisticated we can look how other libraries do it. Ember.js fore example uses Ember.deprecate(): https://github.com/emberjs/ember.js/blob/master/packages/ember-debug/lib/main.js#L94 |
join()
tosearch()
.search()
andget()
'limit'
and'offset'
option insearch()
andget()
.Closes #45.