Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.7 wip #42

Merged
merged 5 commits into from
Dec 25, 2013
Merged

v0.7 wip #42

merged 5 commits into from
Dec 25, 2013

Conversation

mcollina
Copy link
Collaborator

Closes #45.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 444754b on v0.7-wip into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6af24a3 on v0.7-wip into * on master*.

Limit & Offset for get and search
@mcollina
Copy link
Collaborator Author

@elf-pavlik, v0.7-wip is feature complete. It is a 'big' release. Could you please give it a spin and check if there are bugs?

I would love to give some polish to JoinStream and SortJoinStream, but time is up and I think it's better to release this.

@mcollina mcollina merged commit 3658048 into master Dec 25, 2013
@elf-pavlik
Copy link
Member

congratulations for taking it to 0.7 👏

what do you think about adding deprecation warning to join(), or you want to keep this alias for good?

@mcollina
Copy link
Collaborator Author

You are right. I need to add a deprecation warning. Should I just use
console.warn?

@elf-pavlik
Copy link
Member

I think console.warn() should do it for now!

If we need something more sophisticated we can look how other libraries do it. Ember.js fore example uses Ember.deprecate(): https://github.com/emberjs/ember.js/blob/master/packages/ember-debug/lib/main.js#L94
I can try searching in other libraries how they go about deprecating stuff...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nav() before indexedDB is ready causes exception to be thrown
3 participants