forked from jumbojett/OpenID-Connect-PHP
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync with 0.9.7 #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to prevent confusion about Access and ID Token usage.
reset() desires a variable
Some providers require a scope when requesting a token refresh. Uses the same process as requestResourceOwnerToken() due to the RFC requiring the scope to be the same for an access_token request and for a refresh token request
I ran into this issue when trying to set up a basic OAuth flow using this library and Keycloak. The issue was introduced by ce97230 which checks for PKCE support, the way it does this is to call the function getCodeVerifier() which in turn calls getSessionKey() which returns a specified key from _SESSION. This will fail when setting up a client without PKCE because the key will not exist. With this commit a sanity check is introduced which first checks if the key exists in _SESSION before returning it, otherwise just returning false. This should not affect existing library functionality. Signed-off-by: Erik Sjöström <erikdsjostrom@gmail.com>
remove duplicate paragonie/random_compat dependency
Replace error control operator "@" with isset()
Update README.md
Run GH workflow on PHP 8.0 and 8.1
Fix php 8.1
Don't unset headers when using code challenge
fix: allow serializing OpenIDConnectClient
feat: allow passing custom headers to requestTokens()
Fix typos
Fix the following error: Fatal error: Can't use method return value in write context in (...)/src/OpenIDConnectClient.php on line 802
…ue-in-write-context Fix PHP 5.4 bug
Use session_status() to check if session should be started (#306)
Fix error with PHP 5.4
…-PHP into JuliusPC-JuliusPC/cleanup
cleanup: unify formatting, using short array syntax, renaming non public things, adding comment
Implement RFC8693 Token Exchange Request
feat: verify JWT using JWK header
release 0.9.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.