Migrating to Python3 #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify PubChemPy to support Python3 (no backward compatibility with Python2). - Unit testing passed successfully. - Add IPython notebook based on unit testing.
|
Thanks, this looks great. Although I would like to maintain Python 2.7 compatibility at least, so I will look into whether it will be feasible to support both simultaneously with one single codebase. |
|
OK, I've made a few modifications to preserve Python 2.7 support, and now it looks like Python 2.7-3.4 are all supported. I've merged the changes in pull request #4. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Matt,
I have made following modifications to support Python3. Please take note that they are not gonna work on Python2. To support both of them, personally, I have no idea either to have only one set of code with "if-else" all over the place or making extra effort supporting two set of code.
I have converted console unit testing into IPython notebook. Following is the URL to view it on browser.
http://nbviewer.ipython.org/urls/raw.githubusercontent.com/ekaakurniawan/PubChemPy/master/PubChemPy.ipynb?create=1
Regards,
Eka A. Kurniawan