Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is shebang correct? #4

Closed
ahangarha opened this issue Nov 5, 2018 · 3 comments
Closed

Is shebang correct? #4

ahangarha opened this issue Nov 5, 2018 · 3 comments

Comments

@ahangarha
Copy link
Contributor

Hi

Is the shebang at the first line of cheat.py correct? Is it necessary to link it to python in virtual env directory?

I think there is no need to do this since virtualenv itself manage to use the right path to python. Isn't it?

@MCSH
Copy link
Owner

MCSH commented Nov 5, 2018

I think it needs to be /bin/env python and there is a / missing.

Personally, I find it cleaner to use env in order to find the correct python version, although python could be used as well.

Pull Requests are welcome if /bin/env doesn't works on your system and you need to change it

@ahangarha
Copy link
Contributor Author

I made a little research on web and found that using /usr/bin/env python works find withing or without virtualenv. Furthermore, I checked it on my system to make sure there is not problem. Just if one runs the code out of virtualenv, the version of python would be dependent on her default version.

@senaps
Copy link
Contributor

senaps commented Nov 5, 2018

I haven't used the shebang for a really long time, so can't offer any help on that part.
I would fix the setup.py file though and we could use its entry_points, no shebang needed anymore.
and the application would run like before, just by invoking the cheats command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants