Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove force interrupt enabling for Zephyr #302

Closed
carlescufi opened this issue Jun 18, 2018 · 6 comments · Fixed by #1013
Closed

Remove force interrupt enabling for Zephyr #302

carlescufi opened this issue Jun 18, 2018 · 6 comments · Fixed by #1013
Assignees
@carlescufi

Comments

@carlescufi
Copy link
Collaborator

carlescufi commented Jun 18, 2018 •
edited

In boot/zephyr/serial_adapter.c we are currently enabling interrupts due to an issue in the upstream Zephyr: zephyrproject-rtos/zephyr#8393. Remove that once the upstream issue is fixed.
@carlescufi carlescufi self-assigned this Jun 18, 2018
@carlescufi carlescufi mentioned this issue Jun 18, 2018
Closed
@carlescufi
Copy link
Collaborator Author

CC @nvlsianpu

@sigvartmh
Copy link
Contributor

Can this be removed as zephyrproject-rtos/zephyr#9668 is merged?

@carlescufi
Copy link
Collaborator Author

No, because it was reverted here: zephyrproject-rtos/zephyr#9829

@sigvartmh
Copy link
Contributor

I see.

@d3zd3z
Copy link
Member

d3zd3z commented Dec 2, 2019

Any status updates here? Do we need to push a fix into Zephyr?

@carlescufi
Copy link
Collaborator Author

@d3zd3z we need the equivalent of zephyrproject-rtos/zephyr#9668, which was merged but then reverted

carlescufi added a commit to carlescufi/mcuboot that referenced this issue May 19, 2021
@carlescufi
zephyr: serial: Remove unnecessary call to irq_unlock
fc3bfdc 
The following commit in Zephyr removed the need to unlock interrupts
when booting in single-threaded mode:
zephyrproject-rtos/zephyr@3b89cf1

Remove the now obsolete lines.

Fixes mcu-tools#302.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
@carlescufi carlescufi mentioned this issue May 19, 2021
Merged
nvlsianpu pushed a commit that referenced this issue May 20, 2021
@carlescufi @nvlsianpu
zephyr: serial: Remove unnecessary call to irq_unlock
55918ed 
The following commit in Zephyr removed the need to unlock interrupts
when booting in single-threaded mode:
zephyrproject-rtos/zephyr@3b89cf1

Remove the now obsolete lines.

Fixes #302.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlescufi carlescufi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

zephyr: serial: Remove unnecessary call to irq_unlock carlescufi/mcuboot
3 participants
@d3zd3z @sigvartmh @carlescufi