kernel: Enable interrupts for MULTITHREADING=n on supported architect… #9668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some applications have a use case for a tiny MULTITHREADING=n build (which lacks most of the kernel) but still want special-purpose drivers in that mode that might need to handle interupts. This creates a chicken and egg problem, as arch code (for obvious reasons) runs _Cstart() with interrupts disabled, and enables them only on switching into a newly created thread context. Zephyr does not have a "turn interrupts on now, please" API at the architecture level. So this creates one as an arch-specific wrapper around _arch_irq_unlock(). It's implemented as an optional macro the arch can define to enable this behavior, falling back to the previous scheme (and printing a helpful message) if it doesn't find it defined. Only ARM and x86 are enabled in this patch. Fixes zephyrproject-rtos#8393 Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #9668 +/- ##
==========================================
+ Coverage 52.3% 52.31% +<.01%
==========================================
Files 212 212
Lines 25934 25937 +3
Branches 5589 5589
==========================================
+ Hits 13566 13569 +3
Misses 10122 10122
Partials 2246 2246
Continue to review full report at Codecov.
|
nashif
approved these changes
Aug 27, 2018
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ures
Some applications have a use case for a tiny MULTITHREADING=n build
(which lacks most of the kernel) but still want special-purpose
drivers in that mode that might need to handle interupts. This
creates a chicken and egg problem, as arch code (for obvious reasons)
runs _Cstart() with interrupts disabled, and enables them only on
switching into a newly created thread context. Zephyr does not have a
"turn interrupts on now, please" API at the architecture level.
So this creates one as an arch-specific wrapper around
_arch_irq_unlock(). It's implemented as an optional macro the arch
can define to enable this behavior, falling back to the previous
scheme (and printing a helpful message) if it doesn't find it defined.
Only ARM and x86 are enabled in this patch.
Fixes #8393
Signed-off-by: Andy Ross andrew.j.ross@intel.com