-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boot: serial_recovery: Add image hash support #1644
Conversation
We should start relaxing SMP requirements for MCUboot or have some alternative simplified version, because although this completes SMP protocol requirement for image status in reality it does not add that much of a value, as this is recovery protocol and should be rarely used, at the cost of flash. |
I did check the flash before and after and the size increase was minimal (will recheck and get concrete numbers). This is needed where updatable images numbers is > 1 but seems like a useful enough feature even when it is 1 to see if the image was uploaded properly |
without:
116 byte flash increase |
I don't think it's a problem adding the hash, I just think it's useless in this scenario, which is probably why it was not added originally. I think it's even debatable if |
It's probably not useful for serial recovery for the main core, but serial recovery can be used for more than that, e.g. storing images for other cores or other CPUs, in those instances it's useful as you can then query which images are presently loaded on a device, especially if there is a requirement for e.g. 2 cores to have a set of link images because of incompatibilities with different versions and there is a possibility that power can be lost whilst one of the updates is being transferred. |
@nordicjm Can we have some MCUBOOT_CONFIG option turning this off? 100 bytes in flash may not be much, but we struggle to fit other stuff and things keep to add up. |
Added |
Adds support for outputting the image hash TLV in serial recovery mode, which is needed to comply with the img_mgmt MCUmgr group requirements. Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds support for outputting the image hash TLV in serial recovery mode, which is needed to comply with the img_mgmt MCUmgr group requirements.
Fixes #1581
Test file upload and listing from mcuboot:
And checking from actual booted image: