imgtool: Bugfixes and improvements for various imgtool commands #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rustam Ismayilov <rustam.ismayilov@arm.com> Change-Id: I9c84e544b466c0e041bb947fb4dd3e01b0d38ae5
davidvincze
reviewed
Jun 5, 2024
Fixed hash algorithm defaults to SHA256 in case no key provided. Verification improved by adding check for key - tlv mismatch, VerifyResult.KEY_MISMATCH added to indicate this case. Multiple styling fixes and import optimisation, exception handling. Signed-off-by: Rustam Ismayilov <rustam.ismayilov@arm.com> Change-Id: I61a588de5b39678707c0179f4edaa411ceb67c8e
'Measurement Value' added the 'properties' list initially, rather than adding it separately later. Added an assertion to ensure 'Measurement Value' remains as the last item in the 'properties' list Signed-off-by: Rustam Ismayilov <rustam.ismayilov@arm.com> Change-Id: I106059c6c903c3d560477d5114d866f48590ad7e
Add support for dumping images with custom tlv Fix uninitialized access to some variables Fix trailer magic detection Fix some linting issues (parenthesis, indentation, spacing) Signed-off-by: Rustam Ismayilov <rustam.ismayilov@arm.com> Change-Id: I5b6e1dfa74606e2645a258065dd045cc8c7052c5
Fix trailer info dumping reads pad characters as values for status Refactor printing styled texts and frames Use isinstance() for type checking Fold notice text depending on line length Refactoring some parts for readability Fix additional linting issues Signed-off-by: Rustam Ismayilov <rustam.ismayilov@arm.com> Change-Id: I741562bb70b18407bdd32e9c7391048faf6394c6
rustammendel
force-pushed
the
test_imgtool
branch
2 times, most recently
from
3fdb094
to
b806423
Compare
Main method printed hardcoded versions, update to take argument to enable the possibility of testing version strings by invoking the command through command line. Signed-off-by: Rustam Ismayilov <rustam.ismayilov@arm.com> Change-Id: If75769ef223944865313ed95336e859ebef85fd6
rustammendel
force-pushed
the
test_imgtool
branch
from
b806423
to
a39fb9f
Compare
davidvincze
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and improve verify command
Improve readability and reliability of boot_record.py
Fix bugs and add missing features for dumpinfo command
Enable decode_version() to work with command line
Linting and other readability fixes