Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgtool: Bugfixes and improvements for various imgtool commands #1973

Merged
merged 6 commits into from
Jun 14, 2024

Commits on May 29, 2024

  1. imgtool: Add missing requirements to requirements.txt file

    Signed-off-by: Rustam Ismayilov <rustam.ismayilov@arm.com>
    Change-Id: I9c84e544b466c0e041bb947fb4dd3e01b0d38ae5
    rustammendel committed May 29, 2024
    Configuration menu
    Copy the full SHA
    c49cd61 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. imgtool: Fix verify command for edcsa-p384 signed images

    Fixed hash algorithm defaults to SHA256 in case no key provided.
    Verification improved by adding check for key - tlv mismatch,
    VerifyResult.KEY_MISMATCH added to indicate this case.
    Multiple styling fixes and import optimisation, exception handling.
    
    Signed-off-by: Rustam Ismayilov <rustam.ismayilov@arm.com>
    Change-Id: I61a588de5b39678707c0179f4edaa411ceb67c8e
    rustammendel committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    76f62d5 View commit details
    Browse the repository at this point in the history
  2. imgtool: Assert "measurement value" is last in boot_record.py

    'Measurement Value' added the 'properties' list initially,
    rather than adding it separately later.
    Added an assertion to ensure 'Measurement Value' remains as
    the last item in the 'properties' list
    
    Signed-off-by: Rustam Ismayilov <rustam.ismayilov@arm.com>
    Change-Id: I106059c6c903c3d560477d5114d866f48590ad7e
    rustammendel committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    b3afe92 View commit details
    Browse the repository at this point in the history
  3. imgtool: Various dumpinfo fixes

    Add support for dumping images with custom tlv
    Fix uninitialized access to some variables
    Fix trailer magic detection
    Fix some linting issues (parenthesis, indentation, spacing)
    
    Signed-off-by: Rustam Ismayilov <rustam.ismayilov@arm.com>
    Change-Id: I5b6e1dfa74606e2645a258065dd045cc8c7052c5
    rustammendel committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    b00ea2a View commit details
    Browse the repository at this point in the history
  4. imgtool: dumpinfo improvements

    Fix trailer info dumping reads pad characters as values for status
    Refactor printing styled texts and frames
    Use isinstance() for type checking
    Fold notice text depending on line length
    Refactoring some parts for readability
    Fix additional linting issues
    
    Signed-off-by: Rustam Ismayilov <rustam.ismayilov@arm.com>
    Change-Id: I741562bb70b18407bdd32e9c7391048faf6394c6
    rustammendel committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    99dfc91 View commit details
    Browse the repository at this point in the history
  5. imgtool: Update version.py to take command line arguments

    Main method printed hardcoded versions, update to take argument
    to enable the possibility of testing version strings by invoking
    the command through command line.
    
    Signed-off-by: Rustam Ismayilov <rustam.ismayilov@arm.com>
    Change-Id: If75769ef223944865313ed95336e859ebef85fd6
    rustammendel committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    a39fb9f View commit details
    Browse the repository at this point in the history