Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many dpaa2_niX: dpaa2_ni_transmit: drbr_enqueue() failed errors #3

Closed
mcbridematt opened this issue May 8, 2022 · 3 comments
Closed

Many dpaa2_niX: dpaa2_ni_transmit: drbr_enqueue() failed errors #3

mcbridematt opened this issue May 8, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@mcbridematt
Copy link

Hardware: Ten64, MC 10.20 (default DPAA2 configuration)
Commit: 0e7b9be

I've had a Ten64 with FreeBSD serving my audiovisual equipment (TV, set-top box, Xbox) for a week now, it has worked well.

I have noticed these messages appearing in syslog when multiple devices are doing traffic:

May  6 21:52:03 ten64-freebsd kernel: dpaa2_ni2: dpaa2_ni_poll_task: failed to pull frames: chan_id=54, error=16
May  7 03:55:43 ten64-freebsd kernel: dpaa2_ni2: dpaa2_ni_poll_task: failed to pull frames: chan_id=54, error=16
May  7 08:02:16 ten64-freebsd kernel: dpaa2_ni1: dpaa2_ni_transmit: drbr_enqueue() failed
May  7 08:02:16 ten64-freebsd syslogd: last message repeated 5 times
May  7 08:03:46 ten64-freebsd syslogd: last message repeated 8 times
May  7 08:18:06 ten64-freebsd kernel: dpaa2_ni1: dpaa2_ni_transmit: drbr_enqueue() failed
May  7 08:18:17 ten64-freebsd syslogd: last message repeated 23 times
May  8 03:42:54 ten64-freebsd syslogd: last message repeated 1 times
May  8 03:55:20 ten64-freebsd kernel: dpaa2_ni1: dpaa2_ni_transmit: drbr_enqueue() failed
May  8 03:55:20 ten64-freebsd syslogd: last message repeated 7 times
May  8 04:36:25 ten64-freebsd kernel: dpaa2_ni1: dpaa2_ni_transmit: drbr_enqueue() failed
May  8 04:36:25 ten64-freebsd syslogd: last message repeated 13 times

It doesn't happen consistently but enough over two separate occasions.
No major effects (e.g dropped or degraded video streams) are visible on the connected devices

The configuration is:

  • dpni1..3 (GE0..3) bridged as bridge0. Devices are connected on each of these interfaces.
ifconfig bridge0 create
ifconfig bridge0 inet 192.168.13.1/24
ifconfig bridge0 addm dpni0 addm dpni1 addm dpni2 addm dpni3
ifconfig bridge0 up
  • dpni6 (GE6) as 'WAN' interface
  • pf acting as NAT firewall between bridge0 and dpni6

I will try and construct a more repeatable testcase.
@mcbridematt mcbridematt mentioned this issue May 8, 2022
Closed
@dsalychev dsalychev added the bug Something isn't working label May 8, 2022
@dsalychev
Copy link

@mcbridematt Please, try 0e0f350. I've increased a size of the Tx ring buffers to 4096 just for tests.

@dsalychev
Copy link

If you'll be able confirm that drbr_enqueue() fails less frequently with bigger Tx ring buffers, I'll try to improve dpaa2_ni_transmit() in order not to give up on enqueuing mbufs that easy.

@mcbridematt
Copy link
Author

Now that the panic in #4 is out of the way - yes, increasing tx ring buffers has made this warning disappear.

dsalychev pushed a commit that referenced this issue Apr 3, 2023
@rob-wing
FreeBSD: don't verify recycled vnode for zfs control directory
28251d8 
Under certain loads, the following panic is hit:

    panic: page fault
    KDB: stack backtrace:
    #0 0xffffffff805db025 at kdb_backtrace+0x65
    #1 0xffffffff8058e86f at vpanic+0x17f
    #2 0xffffffff8058e6e3 at panic+0x43
    #3 0xffffffff808adc15 at trap_fatal+0x385
    #4 0xffffffff808adc6f at trap_pfault+0x4f
    #5 0xffffffff80886da8 at calltrap+0x8
    #6 0xffffffff80669186 at vgonel+0x186
    #7 0xffffffff80669841 at vgone+0x31
    #8 0xffffffff8065806d at vfs_hash_insert+0x26d
    #9 0xffffffff81a39069 at sfs_vgetx+0x149
    #10 0xffffffff81a39c54 at zfsctl_snapdir_lookup+0x1e4
    #11 0xffffffff8065a28c at lookup+0x45c
    #12 0xffffffff806594b9 at namei+0x259
    #13 0xffffffff80676a33 at kern_statat+0xf3
    #14 0xffffffff8067712f at sys_fstatat+0x2f
    #15 0xffffffff808ae50c at amd64_syscall+0x10c
    #16 0xffffffff808876bb at fast_syscall_common+0xf8

The page fault occurs because vgonel() will call VOP_CLOSE() for active
vnodes. For this reason, define vop_close for zfsctl_ops_snapshot. While
here, define vop_open for consistency.

After adding the necessary vop, the bug progresses to the following
panic:

    panic: VERIFY3(vrecycle(vp) == 1) failed (0 == 1)
    cpuid = 17
    KDB: stack backtrace:
    #0 0xffffffff805e29c5 at kdb_backtrace+0x65
    #1 0xffffffff8059620f at vpanic+0x17f
    #2 0xffffffff81a27f4a at spl_panic+0x3a
    #3 0xffffffff81a3a4d0 at zfsctl_snapshot_inactive+0x40
    #4 0xffffffff8066fdee at vinactivef+0xde
    #5 0xffffffff80670b8a at vgonel+0x1ea
    #6 0xffffffff806711e1 at vgone+0x31
    #7 0xffffffff8065fa0d at vfs_hash_insert+0x26d
    #8 0xffffffff81a39069 at sfs_vgetx+0x149
    #9 0xffffffff81a39c54 at zfsctl_snapdir_lookup+0x1e4
    #10 0xffffffff80661c2c at lookup+0x45c
    #11 0xffffffff80660e59 at namei+0x259
    #12 0xffffffff8067e3d3 at kern_statat+0xf3
    #13 0xffffffff8067eacf at sys_fstatat+0x2f
    #14 0xffffffff808b5ecc at amd64_syscall+0x10c
    #15 0xffffffff8088f07b at fast_syscall_common+0xf8

This is caused by a race condition that can occur when allocating a new
vnode and adding that vnode to the vfs hash. If the newly created vnode
loses the race when being inserted into the vfs hash, it will not be
recycled as its usecount is greater than zero, hitting the above
assertion.

Fix this by dropping the assertion.

FreeBSD-issue: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252700
Reviewed-by: Andriy Gapon <avg@FreeBSD.org>
Reviewed-by: Mateusz Guzik <mjguzik@gmail.com>
Reviewed-by: Alek Pinchuk <apinchuk@axcient.com>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Rob Wing <rob.wing@klarasystems.com>
Co-authored-by: Rob Wing <rob.wing@klarasystems.com>
Submitted-by: Klara, Inc.
Sponsored-by: rsync.net
Closes #14501
dsalychev pushed a commit that referenced this issue Aug 3, 2023
@kprovost
mroute: avoid calling if_allmulti with the lock held
680ad06 
Avoid locking issues when if_allmulti() calls the driver's if_ioctl,
because that may acquire sleepable locks (while we hold a non-sleepable
rwlock).

Fortunately there's no pressing need to hold the mroute lock while we
do this, so we can postpone the call slightly, until after we've
released the lock.

This avoids the following WITNESS warning (with iflib drivers):

	lock order reversal: (sleepable after non-sleepable)
	 1st 0xffffffff82f64960 IPv4 multicast forwarding (IPv4 multicast forwarding, rw) @ /usr/src/sys/netinet/ip_mroute.c:1050
	 2nd 0xfffff8000480f180 iflib ctx lock (iflib ctx lock, sx) @ /usr/src/sys/net/iflib.c:4525
	lock order IPv4 multicast forwarding -> iflib ctx lock attempted at:
	#0 0xffffffff80bbd6ce at witness_checkorder+0xbbe
	#1 0xffffffff80b56d10 at _sx_xlock+0x60
	#2 0xffffffff80c9ce5c at iflib_if_ioctl+0x2dc
	#3 0xffffffff80c7c395 at if_setflag+0xe5
	#4 0xffffffff82f60a0e at del_vif_locked+0x9e
	#5 0xffffffff82f5f0d5 at X_ip_mrouter_set+0x265
	#6 0xffffffff80bfd402 at sosetopt+0xc2
	#7 0xffffffff80c02105 at kern_setsockopt+0xa5
	#8 0xffffffff80c02054 at sys_setsockopt+0x24
	#9 0xffffffff81046be8 at amd64_syscall+0x138
	#10 0xffffffff8101930b at fast_syscall_common+0xf8

See also:	https://redmine.pfsense.org/issues/12079
Reviewed by:	mjg
Sponsored by:	Rubicon Communications, LLC ("Netgate")
Differential Revision:	https://reviews.freebsd.org/D41209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsalychev @mcbridematt