Tie to latest compatible react commit #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks for noticing it and fix it. I will merge it but will try to change the code next weekend to avoid depending on this. |
|
I looked at fixing it. You rely on getRemoteAddress() which has become a public property of the Request object so is fine. But getBody() has gone completely and there seems no replacement yet. However in the PR I linked to they do say that they want to replace the functionality as soon as possible. So hopefully it'll be back soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ties react/http to a particular commit as they just backed out a load of code that phiremock relies on (reactphp/http#59)