Viz not recover after error

[mstefaniuk]

When Viz is called subsequently (the same instance) it cannot recover when unclosed quotes error is thrown. Failing case looks as follows:

define(["viz"], function(viz) {

  describe("Viz.js", function() {
    it("should recover after unclosed quotes error", function() {
      expect(function() {
        viz([
          'digraph {',
          ' a -> b [label="erroneous]',
          '}'].join("\n"));
      }).toThrow();
      var svg = viz([
        'digraph {',
        ' a -> b [label="correcteous"]',
        '}'].join("\n"));
      expect(svg).toBeDefined();
    });
  });
});

First call throws an exception with Error: syntax error in line 2 near '' as expected. Subsequent gives Error: syntax error in line 1 near '"' until new Viz instance is created.

Viz is loaded using require.js with shim.

[jackycute]

We also experienced this issue.

[mdaines]

c687a63 should address this. I am attaching a build of that version for testing.

viz.js.zip

[jackycute]

I just tested it, it works.
But the error message seems a bit weird.

abort() at Error
If this abort() is unexpected, build with -s ASSERTIONS=1 which can give more information.

[mdaines]

So it does. I'll update the test to check for the correct error message and see if I can find the problem.

[mdaines]

This should be addressed in 2257a40 and the fix will be in the next release.