Skip to content

Commit

Permalink
Increase num_levels for universal from 8 to 40
Browse files Browse the repository at this point in the history
Summary:
See facebook#10082 for more details. Trivial move
isn't done for universal when compaction is from L0 into L0. So a too small value for
num_levels with db_bench means there will be fewer trivial moves with universal and
that means that write-amp will increase.

Test Plan:

run it

Reviewers:

Subscribers:

Tasks:

Tags:
  • Loading branch information
mdcallag committed Jun 13, 2022
1 parent ad135f3 commit 2631a99
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tools/benchmark.sh
Expand Up @@ -233,7 +233,6 @@ const_params_base="
--wal_dir=$WAL_DIR \
\
--num=$num_keys \
--num_levels=8 \
--key_size=$key_size \
--value_size=$value_size \
--block_size=$block_size \
Expand Down Expand Up @@ -271,6 +270,7 @@ const_params_base="
level_const_params="
$const_params_base \
--compaction_style=0 \
--num_levels=8 \
--min_level_to_compress=$min_level_to_compress \
--level_compaction_dynamic_level_bytes=true \
--pin_l0_filter_and_index_blocks_in_cache=1 \
Expand All @@ -295,6 +295,7 @@ blob_const_params="
univ_const_params="
$const_params_base \
--compaction_style=1 \
--num_levels=40 \
--universal_compression_size_percent=$compression_size_percent \
--pin_l0_filter_and_index_blocks_in_cache=1 \
--universal_min_merge_width=$univ_min_merge_width \
Expand Down

0 comments on commit 2631a99

Please sign in to comment.