Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve activity buttons without tool buttons #176

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

szschaler
Copy link
Contributor

This PR fixes a problem where activity-defined buttons would only be shown if there were any buttons defined in the panel definition, too.

@szschaler szschaler self-assigned this Feb 9, 2024
@szschaler szschaler added the bug Something isn't working label Feb 9, 2024
Copy link
Collaborator

@barnettwilliam barnettwilliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szschaler szschaler merged commit 2c58019 into main Feb 9, 2024
2 checks passed
@szschaler szschaler deleted the fix/activity-btns-without-tool-btns branch February 9, 2024 17:01
barnettwilliam added a commit to mdenet/educationplatform-docker that referenced this pull request Feb 18, 2024
…token server use ref when loading files, mdenet/educationplatform#178 token server correctly report activity access issues, mdenet/educationplatform#176 resolve activity buttons without tool buttons, mdenet/educationplatform#175 report all errors on startup, mdenet/platformtools#59 added endpoint documentation, and mdenet/platformtools#57 xmi support for epsilon editor config.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants