Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import AUTHORS from nose #31

Closed
wants to merge 3 commits into from
Closed

Import AUTHORS from nose #31

wants to merge 3 commits into from

Conversation

astatide
Copy link

@astatide astatide commented Jul 9, 2024

The following PR adds the original AUTHORS file from the nose repository, ensuring proper attribution is given.

@emilazy
Copy link

emilazy commented Jul 9, 2024

Could you add Michael Mintz and Christian Clauss so that this has a more complete list of contributors/copyright holders?

@emilazy emilazy mentioned this pull request Jul 9, 2024
2 tasks
@astatide
Copy link
Author

astatide commented Jul 9, 2024

Hmmm, in that case, it might be better to move this up a directory (as it is, I just tried to pull it into the original location of the AUTHORS file from the nose directory).

@emilazy
Copy link

emilazy commented Jul 9, 2024

It’s in the root of the upstream nose repository, too, not the nose subdirectory both share, so I think that placement with the rest of the meta files rather than the Python source directory makes more sense.

@astatide
Copy link
Author

astatide commented Jul 9, 2024

Ah, I thought the subdirectory they shared was a little different. However, I think even if that were the case, it makes more sense to have it in the root and with all authors. Thank you for the suggestion!

Copy link

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, but @mdmintz will of course need to review/merge.

@mdmintz
Copy link
Owner

mdmintz commented Jul 9, 2024

Do we know why "John Szakmeister" is missing from the original AUTHORS file? He was a major contributor to the original nose. (A few other missing too. I'm looking into it)

@mdmintz
Copy link
Owner

mdmintz commented Jul 9, 2024

Take a look at #32 (I added missing authors, reordered a bit based on lines of code)

@mdmintz
Copy link
Owner

mdmintz commented Jul 9, 2024

Completed in #32
Now there are 38 authors listed, including some ones that were missing in https://github.com/nose-devs/nose/blob/master/AUTHORS

@mdmintz mdmintz closed this Jul 9, 2024
@astatide
Copy link
Author

astatide commented Jul 9, 2024

Look, I’ll be honest with you. I opened this PR because you complained you were busy and had a lot of things to take care of, and I wanted to provide a way for you to make it look like you weren’t just trying to make it look like you did all the work on this project. So your response of opening a second PR that’s a slightly modified version of this, merging yours, and closing this? Really makes it look like you’re doing exactly that.

Sure, it took me less than 30 seconds to make this PR and I have no interest in actually contributing to your project, but you claimed you were busy and this was too much work so I took a proactive helpful approach.

Making a separate PR that your GitHub history gets credit for (your GitHub history already has credit for the massive commit/PR you did with the nose project here) is literally the exact behavior you should be avoiding and that you claimed you weren’t doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants