Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisualViewport Browser Compatibility #4928

Closed
nitishk72 opened this issue Oct 4, 2019 · 2 comments
Closed

VisualViewport Browser Compatibility #4928

nitishk72 opened this issue Oct 4, 2019 · 2 comments
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Comments

@nitishk72
Copy link

nitishk72 commented Oct 4, 2019

I saw on twitter that iOS13 supports visual viewport. I don't know exactly how to update the docs that's why I creating the issue instead of sending the pull request.

Ref : https://twitter.com/jesper_vos/status/1179673256925814785
Screenshot 2019-10-04 at 2 05 19 PM

@germain-gg
Copy link
Contributor

Hey @nitishk72 ,

Thank you for raising this issue,

You can fork this repo and then update the file api/VisualViewport.json. You will find a good contributing guide on here

Looking at the Safari 13 release notes, it seems that there is added support for VisualViewport on that browser version.

I'm wondering whether we should open a broader issue to review the compat data for everything mentioned in that release log (ping @Elchi3 ?)

@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 5, 2019
@queengooborg
Copy link
Collaborator

This has actually already been fixed by #4850, which added the compatibility data for Safari 13 for VisualViewport. As such, I'm closing this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

No branches or pull requests

3 participants