-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add URL API #1122
Add URL API #1122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for your pull request! Welcome to mdn-browser-compat-data. Sorry for not coming back to you earlier, the repo is quite busy.
I left some comments and they also apply to else where in the file. Can you fix these?
Also the constructor is missing as a sub feature here, https://developer.mozilla.org/en-US/docs/Web/API/URL/URL
Thanks for your work!
api/URL.json
Outdated
{ | ||
"version_added": "2", | ||
"alternative_name": "webkitURL", | ||
"notes": "This feature is implemented under the non-standard name webkitURL." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note is redundant. Please remove
api/URL.json
Outdated
"notes": "This feature is implemented under the non-standard name webkitURL." | ||
}, | ||
{ | ||
"version_added": "32" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you swap this around to be reverse chronological, please?
[
{ version_added: 32 },
{ version_added: 2, alternative_name: webkitURL}
]
api/URL.json
Outdated
"notes": "From Gecko 2 (Firefox 4) to Gecko 18 included, Gecko supported this interface with the non-standard nsIDOMMozURLProperty internal type. As the only to access such an object was through window.URL, in practice, this didn't make any difference." | ||
}, | ||
{ | ||
"version_added": "19" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverse chronological please. version 19 is the most relevant version that should appear in the main cell.
api/URL.json
Outdated
"version_added": "15", | ||
"alternative_name": "webkitURL", | ||
"notes": [ | ||
"This feature is implemented under the non-standard name webkitURL." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note is redundant, please remove
api/URL.json
Outdated
] | ||
}, | ||
{ | ||
"version_added": "19" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to come first
api/URL.json
Outdated
"version_added": "6", | ||
"alternative_name": "webkitURL", | ||
"notes": [ | ||
"This feature is implemented under the non-standard name webkitURL." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
api/URL.json
Outdated
] | ||
}, | ||
{ | ||
"version_added": "7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this version first
@Elchi3 Updated now! |
Wow, nice work! I really like the idea of little helper scripts. Would you mind putting that into a new PR, though? Allows us to have a separate discussion about how we want to add this. Looks good otherwise except that the constructor is still missing as a sub feature, https://developer.mozilla.org/en-US/docs/Web/API/URL/URL |
I'll make a new PR with that! :)
I don't fully understand. Isn't the first __compat the constructor? 🤔 |
The first __compat is the URL interface itself (and some interfaces have no constructor). |
Thanks! |
@Elchi3 Added constructor now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
Render: https://ipfs.io/ipfs/QmaL7X5G8ESzhmv45MDJKNg11GDpe1TVVWBtcR2jXTV64u/
Based on: