Add URL API #1122

enjikaka · 2018-02-17T11:23:53Z

Render: https://ipfs.io/ipfs/QmaL7X5G8ESzhmv45MDJKNg11GDpe1TVVWBtcR2jXTV64u/
Based on:

https://developer.mozilla.org/en-US/docs/Web/API/URL
https://developer.microsoft.com/en-us/microsoft-edge/platform/catalog/?q=specName%3Awhatwg-url
Some own testing in Opera

Elchi3

Hey, thanks for your pull request! Welcome to mdn-browser-compat-data. Sorry for not coming back to you earlier, the repo is quite busy.

I left some comments and they also apply to else where in the file. Can you fix these?
Also the constructor is missing as a sub feature here, https://developer.mozilla.org/en-US/docs/Web/API/URL/URL

Thanks for your work!

Elchi3 · 2018-03-06T10:06:29Z

api/URL.json

+            {
+              "version_added": "2",
+              "alternative_name": "webkitURL",
+              "notes": "This feature is implemented under the non-standard name webkitURL."


This note is redundant. Please remove

Elchi3 · 2018-03-06T10:12:58Z

api/URL.json

+              "notes": "This feature is implemented under the non-standard name webkitURL."
+            },
+            {
+              "version_added": "32"


Can you swap this around to be reverse chronological, please?
[
{ version_added: 32 },
{ version_added: 2, alternative_name: webkitURL}
]

Elchi3 · 2018-03-06T10:14:52Z

api/URL.json

+              "notes": "From Gecko 2 (Firefox 4) to Gecko 18 included, Gecko supported this interface with the non-standard nsIDOMMozURLProperty internal type. As the only to access such an object was through window.URL, in practice, this didn't make any difference."
+            },
+            {
+              "version_added": "19"


Reverse chronological please. version 19 is the most relevant version that should appear in the main cell.

Elchi3 · 2018-03-06T10:15:09Z

api/URL.json

+              "version_added": "15",
+              "alternative_name": "webkitURL",
+              "notes": [
+                "This feature is implemented under the non-standard name webkitURL."


note is redundant, please remove

Elchi3 · 2018-03-06T10:15:21Z

api/URL.json

+              ]
+            },
+            {
+              "version_added": "19"


This needs to come first

Elchi3 · 2018-03-06T10:15:31Z

api/URL.json

+              "version_added": "6",
+              "alternative_name": "webkitURL",
+              "notes": [
+                "This feature is implemented under the non-standard name webkitURL."


Elchi3 · 2018-03-06T10:15:41Z

api/URL.json

+              ]
+            },
+            {
+              "version_added": "7"


Put this version first

enjikaka · 2018-03-07T18:51:48Z

@Elchi3 Updated now!
New render: https://ipfs.io/ipfs/QmPEtEfwV33GS2urkLRubTR3LoirX2cNFa8k5fJQzcKgUX/

Elchi3 · 2018-03-08T11:37:39Z

Wow, nice work! I really like the idea of little helper scripts. Would you mind putting that into a new PR, though? Allows us to have a separate discussion about how we want to add this.

Looks good otherwise except that the constructor is still missing as a sub feature, https://developer.mozilla.org/en-US/docs/Web/API/URL/URL

enjikaka · 2018-03-08T11:57:27Z

Wow, nice work! I really like the idea of little helper scripts. Would you mind putting that into a new PR, though? Allows us to have a separate discussion about how we want to add this.

I'll make a new PR with that! :)

as a sub feature

I don't fully understand. Isn't the first __compat the constructor? 🤔

Elchi3 · 2018-03-08T11:59:14Z

The first __compat is the URL interface itself (and some interfaces have no constructor).

enjikaka · 2018-03-08T12:08:09Z

@Elchi3 Ok, I'll look over the file again and try to understand what to change and get it sorted! Meanwhile; here's a PR for the helper script: #1314

Elchi3 · 2018-03-08T12:10:37Z

Thanks!
Have a look at other APIs, like https://github.com/mdn/browser-compat-data/blob/master/api/AnalyserNode.json which also has a constructor (api.AnalyserNode.AnalyserNode).

enjikaka · 2018-03-08T12:16:53Z

@Elchi3 Added constructor now!

Elchi3

Awesome, thank you!

enjikaka added 4 commits February 17, 2018 12:00

Add JSON for URL

62aeeaf

Add props

674ecd1

Fix linting errors

f146615

Rm some browsers

64f1426

Elchi3 added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 18, 2018

Elchi3 added this to In Progress / Review Needed in Migration of compat data from MDN pages Feb 18, 2018

Elchi3 requested changes Mar 6, 2018

View reviewed changes

enjikaka added 5 commits March 7, 2018 19:13

Remove redundant note

98b24a3

Add script for sorting versions

de516a7

Use the script for sorting versions

424dbbc

Add comments to sort-versions script

d726189

Remove all notes for webkit where there is alternative_name

755a610

Use first key in apiName const

6ce5b21

enjikaka mentioned this pull request Mar 8, 2018

Add helper script for sorting browser versions #1314

Closed

enjikaka added 2 commits March 8, 2018 13:12

Remove helper scrips. Check PR mdn#1314

a60bb2a

Add constructor

83be1be

Remove locale from mdn_url

8364504

Elchi3 approved these changes Mar 8, 2018

View reviewed changes

Elchi3 merged commit babbb0d into mdn:master Mar 8, 2018

Migration of compat data from MDN pages automation moved this from In Progress / Review Needed to MDN page updates needed Mar 8, 2018

enjikaka deleted the URL branch March 8, 2018 14:12

Elchi3 moved this from MDN page updates needed to Done in Migration of compat data from MDN pages Mar 9, 2018

dontcallmedom pushed a commit to dontcallmedom/browser-compat-data that referenced this pull request Mar 17, 2018

Add compat data for URL API (mdn#1122)

dbcc470

mlbrgl pushed a commit to mlbrgl/browser-compat-data that referenced this pull request Mar 29, 2018

Add compat data for URL API (mdn#1122)

67b2377

caugner mentioned this pull request Jul 19, 2018

lint: add consistency check #2463

Closed

estelle mentioned this pull request Apr 25, 2019

Add description to reset and submit events #3990

Merged

Woodpile37 mentioned this pull request Aug 21, 2023

[Snyk] Upgrade eslint-plugin-jsdoc from 40.0.0 to 46.4.5 Woodpile37/browser-compat-data#7

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add URL API #1122

Add URL API #1122

enjikaka commented Feb 17, 2018 •

edited

Elchi3 left a comment

Elchi3 Mar 6, 2018

Elchi3 Mar 6, 2018

Elchi3 Mar 6, 2018

Elchi3 Mar 6, 2018

Elchi3 Mar 6, 2018

Elchi3 Mar 6, 2018

Elchi3 Mar 6, 2018

enjikaka commented Mar 7, 2018 •

edited

Elchi3 commented Mar 8, 2018

enjikaka commented Mar 8, 2018

Elchi3 commented Mar 8, 2018

enjikaka commented Mar 8, 2018

Elchi3 commented Mar 8, 2018

enjikaka commented Mar 8, 2018

Elchi3 left a comment

Add URL API #1122

Add URL API #1122

Conversation

enjikaka commented Feb 17, 2018 • edited

Elchi3 left a comment

Choose a reason for hiding this comment

Elchi3 Mar 6, 2018

Choose a reason for hiding this comment

Elchi3 Mar 6, 2018

Choose a reason for hiding this comment

Elchi3 Mar 6, 2018

Choose a reason for hiding this comment

Elchi3 Mar 6, 2018

Choose a reason for hiding this comment

Elchi3 Mar 6, 2018

Choose a reason for hiding this comment

Elchi3 Mar 6, 2018

Choose a reason for hiding this comment

Elchi3 Mar 6, 2018

Choose a reason for hiding this comment

enjikaka commented Mar 7, 2018 • edited

Elchi3 commented Mar 8, 2018

enjikaka commented Mar 8, 2018

Elchi3 commented Mar 8, 2018

enjikaka commented Mar 8, 2018

Elchi3 commented Mar 8, 2018

enjikaka commented Mar 8, 2018

Elchi3 left a comment

Choose a reason for hiding this comment

enjikaka commented Feb 17, 2018 •

edited

enjikaka commented Mar 7, 2018 •

edited