Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chromium versions for StorageManager API #11698

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR updates and corrects the real values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the StorageManager API, based upon results from the mdn-bcd-collector project (v3.2.2).

Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/StorageManager

This PR updates and corrects the real values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `StorageManager` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v3.2.2).

Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/StorageManager
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 23, 2021
@foolip
Copy link
Collaborator

foolip commented Jul 23, 2021

Let's see... this data came from #2272 with reference to https://chromium.googlesource.com/chromium/src/+/21ba553558ed7cd65f59199b28dd8732f5dc93a0%5E%21/third_party/WebKit/Source/modules/quota/StorageManager.idl but without mentioning RuntimeEnabled=DurableStorage in the IDL. So I don't trust the original data.

@@ -6,10 +6,10 @@
"spec_url": "https://storage.spec.whatwg.org/#storagemanager",
"support": {
"chrome": {
"version_added": "48"
"version_added": "55"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}
],
"chrome": {
"version_added": "55"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}
],
"chrome": {
"version_added": "55"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -54,10 +54,10 @@
"spec_url": "https://storage.spec.whatwg.org/#ref-for-dom-storagemanager-estimate",
"support": {
"chrome": {
"version_added": "52"
"version_added": "61"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"version_added": "52"
},
{
"alternative_name": "requestPersistent",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting this stuff that was never in stable Chrome is 👍

@foolip foolip merged commit c53942a into mdn:main Jul 23, 2021
@queengooborg queengooborg deleted the api/StorageManager/chrome-corrections branch July 23, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants