API/StorageManager: add compat data #2272

caugner · 2018-06-09T20:39:47Z

Sources:

MDN article:
https://developer.mozilla.org/en-US/docs/Web/API/StorageManager#Browser_compatibility
Chromium repository:
https://chromium.googlesource.com/chromium/src/+/21ba553558ed7cd65f59199b28dd8732f5dc93a0%5E%21/third_party/WebKit/Source/modules/quota/StorageManager.idl (initial)
https://chromium.googlesource.com/chromium/src/+/703806a09a9c9dc295e29c86d079dfef4dc67f40%5E!/third_party/WebKit/Source/modules/quota/StorageManager.idl (estimate)
https://chromium.googlesource.com/chromium/src/+/0b5bf0fd87c2dad9b2c7223a20f2b8b7756f3e57%5E%21/third_party/WebKit/Source/modules/quota/StorageManager.idl (persisted, persist)
Firefox bug tracker:
https://bugzil.la/1267941 (estimate)
https://bugzil.la/1286717 (persist, persisted)
Firefox repository:
https://github.com/mozilla/gecko-dev/blob/ba9fa0d68ab991dd0eb90ab6545e82a38abf5678/dom/webidl/StorageManager.webidl (initial)
https://github.com/mozilla/gecko-dev/blob/04b9cbbc2be2137a37e158a5ebaf9c7bef2364f9/dom/webidl/StorageManager.webidl (status quo)
https://github.com/mozilla/gecko-dev/blob/04b9cbbc2be2137a37e158a5ebaf9c7bef2364f9/modules/libpref/init/all.js#L5723-L5727 (flag on Android)

Sources: 1. MDN article: https://developer.mozilla.org/en-US/docs/Web/API/StorageManager#Browser_compatibility 2. Chromium repository: https://chromium.googlesource.com/chromium/src/+/21ba553558ed7cd65f59199b28dd8732f5dc93a0%5E%21/third_party/WebKit/Source/modules/quota/StorageManager.idl (initial) https://chromium.googlesource.com/chromium/src/+/703806a09a9c9dc295e29c86d079dfef4dc67f40%5E!/third_party/WebKit/Source/modules/quota/StorageManager.idl (estimate) https://chromium.googlesource.com/chromium/src/+/0b5bf0fd87c2dad9b2c7223a20f2b8b7756f3e57%5E%21/third_party/WebKit/Source/modules/quota/StorageManager.idl (persisted, persist) 3. Firefox bug tracker: https://bugzil.la/1267941 (estimate) https://bugzil.la/1286717 (persist, persisted) 4. Firefox repository: https://github.com/mozilla/gecko-dev/blob/ba9fa0d68ab991dd0eb90ab6545e82a38abf5678/dom/webidl/StorageManager.webidl (initial) https://github.com/mozilla/gecko-dev/blob/04b9cbbc2be2137a37e158a5ebaf9c7bef2364f9/dom/webidl/StorageManager.webidl (status quo) https://github.com/mozilla/gecko-dev/blob/04b9cbbc2be2137a37e158a5ebaf9c7bef2364f9/modules/libpref/init/all.js#L5723-L5727 (flag on Android)

caugner · 2018-06-09T20:53:47Z

api/StorageManager.json

@@ -5,34 +5,56 @@
        "mdn_url": "https://developer.mozilla.org/docs/Web/API/StorageManager",


First of all, I have added the compat data despite the ongoing discussion in #190 about representing the "secure context" requirement.

In my opinion, a browser could be considered compatible if it offers the feature in the secure context as defined by the spec. On the other hand, I wouldn't consider a browser incompatible, if it also offers the feature outside of the [required] secure context, but instead point this out in a "notes" entry.

caugner · 2018-06-09T20:54:32Z

api/StorageManager.json

          },
          "chrome": {
-            "version_added": null
+            "version_added": "48"


MDN stated 55, but basic and full support was already established in 48 and 52 respectively:

Diff adding persist and persisted with alternative names in 48.

Diff adding estimate in 52.

Diff renaming persist/persisted in 52.

caugner · 2018-06-09T20:59:57Z

api/StorageManager.json

+                {
+                  "type": "preference",
+                  "name": "dom.storageManager.enabled",
+                  "value_to_set": "true"


MDN stated that, from version 55, the preference browser.storageManager.enabled was also required, but I found no evidence for this (neither in the repository nor in the bugs).

caugner · 2018-06-09T21:00:52Z

api/StorageManager.json

+              {
+                "type": "preference",
+                "name": "dom.storageManager.enabled",
+                "value_to_set": "true"


MDN did not mention yet that the feature is still be behind a flag on Android:
https://github.com/mozilla/gecko-dev/blob/04b9cbbc2be2137a37e158a5ebaf9c7bef2364f9/modules/libpref/init/all.js#L5723-L5727

caugner · 2018-06-09T21:03:43Z

api/StorageManager.json

          },
          "ie": {
            "version_added": null
          },
          "opera": {
-            "version_added": null
+            "version_added": true


Since I updated the Chrome versions and am not aware of a Chrome version to Opera version mapping (like [the one for Samsung Internet]), I have reset these versions to true.

Opera is usually Chrome - 13, so in this case 35. But I've always been a little bit uncomfortable doing that on an automatic basis, so you don't actually have to change this. I'll leave it up to your judgment

ddbeck

Nice research on this @caugner. A few points, but this is pretty close. Thank you!

ddbeck · 2018-07-20T17:59:20Z

api/StorageManager.json

+            {
+              "version_added": "51",
+              "version_removed": "57",
+              "notes": "See <a href='https://bugzil.la/1304966'>Bug 1304966</a> and <a href='https://bugzil.la/1399038'>Bug 1399038</a>.",


I don't think we routinely capitalize "bug"

Thanks! I just that in 274f8ab and added issue #2509 to potentially check this as part of linting.

ddbeck · 2018-07-20T18:00:09Z

api/StorageManager.json

          "firefox_android": {
-            "version_added": null
+            "version_added": "51",
+            "notes": "See <a href='https://bugzil.la/1304966'>Bug 1304966</a> and <a href='https://bugzil.la/1399038'>Bug 1399038</a>.",


Bug capitalization here too

ddbeck · 2018-07-20T18:01:23Z

api/StorageManager.json

          },
          "ie": {
            "version_added": null
          },
          "opera": {
-            "version_added": null
+            "version_added": true


Opera is usually Chrome - 13, so in this case 35. But I've always been a little bit uncomfortable doing that on an automatic basis, so you don't actually have to change this. I'll leave it up to your judgment

ddbeck · 2018-07-20T18:03:27Z

api/StorageManager.json

@@ -5,34 +5,56 @@
        "mdn_url": "https://developer.mozilla.org/docs/Web/API/StorageManager",
        "support": {
          "webview_android": {


Since I've suggested other changes, may as well sort the browsers too

Good idea, I just did that in 4125b1a.

caugner · 2018-07-20T21:09:25Z

@ddbeck Regarding the Opera version (for some reason I cannot directly reply to that comment), I would think it's better – for the sake of traceability – to make such derivations systematically in a PR dedicated to that purpose.

ddbeck · 2018-07-20T21:37:42Z

Good idea! I opened #2510 to tackle the question generally.

ddbeck

Thank you @caugner! 🎉

foolip · 2021-07-23T22:26:49Z

3 years have passed, but I thought I'd point out for anyone subscribed to this PR that there was a problem with how the Chromium versions were determined. Just looking at when Web IDL was added to Chromium isn't reliable, because it can still be behind a runtime flag. In this case, that's the RuntimeEnabled=DurableStorage in https://chromium.googlesource.com/chromium/src/+/21ba553558ed7cd65f59199b28dd8732f5dc93a0%5E%21/third_party/WebKit/Source/modules/quota/StorageManager.idl

The data is being updated in #11698.

caugner commented Jun 9, 2018

View reviewed changes

Elchi3 added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 13, 2018

ddbeck requested changes Jul 20, 2018

View reviewed changes

caugner added 2 commits July 20, 2018 22:46

StorageManager: fix bug capitalization

274f8ab

StorageManager: sort status

4125b1a

ddbeck mentioned this pull request Jul 20, 2018

Derive Opera data from Chrome #2510

Closed

ddbeck approved these changes Jul 20, 2018

View reviewed changes

ddbeck merged commit d678f5b into mdn:master Jul 20, 2018

caugner deleted the API/StorageManager branch July 20, 2018 22:13

foolip mentioned this pull request Jul 23, 2021

Update Chromium versions for StorageManager API #11698

Merged

GPHemsley mentioned this pull request Jan 3, 2022

Missing StorageQuota support Fyrd/caniuse#3246

Open

GPHemsley mentioned this pull request Jan 17, 2022

Quota Management API Fyrd/caniuse#1277

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API/StorageManager: add compat data #2272

API/StorageManager: add compat data #2272

caugner commented Jun 9, 2018

caugner Jun 9, 2018

caugner Jun 9, 2018 •

edited

Loading

caugner Jun 9, 2018

caugner Jun 9, 2018

caugner Jun 9, 2018

ddbeck Jul 20, 2018

ddbeck left a comment

ddbeck Jul 20, 2018

caugner Jul 20, 2018 •

edited

Loading

ddbeck Jul 20, 2018

caugner Jul 20, 2018

ddbeck Jul 20, 2018

ddbeck Jul 20, 2018

caugner Jul 20, 2018

caugner commented Jul 20, 2018 •

edited

Loading

ddbeck commented Jul 20, 2018

ddbeck left a comment

foolip commented Jul 23, 2021

		@@ -5,34 +5,56 @@
		"mdn_url": "https://developer.mozilla.org/docs/Web/API/StorageManager",

API/StorageManager: add compat data #2272

API/StorageManager: add compat data #2272

Conversation

caugner commented Jun 9, 2018

Choose a reason for hiding this comment

caugner Jun 9, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ddbeck left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

caugner Jul 20, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

caugner commented Jul 20, 2018 • edited Loading

ddbeck commented Jul 20, 2018

ddbeck left a comment

Choose a reason for hiding this comment

foolip commented Jul 23, 2021

caugner Jun 9, 2018 •

edited

Loading

caugner Jul 20, 2018 •

edited

Loading

caugner commented Jul 20, 2018 •

edited

Loading