Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yargs from 17.0.1 to 17.1.0 #11916

Merged
merged 1 commit into from Aug 6, 2021
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 5, 2021

Bumps yargs from 17.0.1 to 17.1.0.

Changelog

Sourced from yargs's changelog.

17.1.0 (2021-08-04)

Features

  • update Levenshtein to Damerau-Levenshtein (#1973) (d2c121b)

Bug Fixes

  • coerce middleware should be applied once (#1978) (14bd6be)
  • implies should not fail when implied key's value is 0, false or empty string (#1985) (8010472)
  • positionals should not overwrite options (#1992) (9d84309)
  • strict should fail unknown arguments (#1977) (c804f0d)
  • wrap(null) no longer causes strange indentation behavior (#1988) (e1871aa)
Commits
  • 5d53144 chore: release 17.1.0 (#1984)
  • 54837eb build: use denoland/setup-deno (#1991)
  • e1871aa fix: wrap(null) no longer causes strange indentation behavior (#1988)
  • b737d68 chore(deps): update dependency @​types/mocha to v9 (#1993)
  • 9d84309 fix: positionals should not overwrite options (#1992)
  • 8010472 fix: implies should not fail when implied key's value is 0, false or empty st...
  • 14bd6be fix: coerce middleware should be applied once (#1978)
  • d2c121b feat: update Levenshtein to Damerau-Levenshtein (#1973)
  • c804f0d fix: strict should fail unknown arguments (#1977)
  • 5478611 i18n: Update zh_TW.json (#1976)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [yargs](https://github.com/yargs/yargs) from 17.0.1 to 17.1.0.
- [Release notes](https://github.com/yargs/yargs/releases)
- [Changelog](https://github.com/yargs/yargs/blob/master/CHANGELOG.md)
- [Commits](yargs/yargs@v17.0.1...v17.1.0)

---
updated-dependencies:
- dependency-name: yargs
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from ddbeck as a code owner August 5, 2021 11:00
@dependabot dependabot bot added the dependencies ⛓️ Pull requests that update a dependency package or file. label Aug 5, 2021
@github-actions github-actions bot added the infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project label Aug 5, 2021
@ddbeck ddbeck merged commit eeb15c3 into main Aug 6, 2021
@ddbeck ddbeck deleted the dependabot/npm_and_yarn/yargs-17.1.0 branch August 6, 2021 11:00
@foolip
Copy link
Collaborator

foolip commented Aug 12, 2021

This upgrade has regression npm run traverse. Now, the version argument seems to have no effect at all, where npm run traverse chrome api 10 and npm run traverse chrome api 90 lists the same 378 entries.

foolip added a commit to foolip/browser-compat-data that referenced this pull request Aug 12, 2021
mdn#11916 broke the traverse
script, probably due to yargs/yargs#1992.

The problem now is that for `npm run chrome all 90`, `values`
will be ["null", "true", "90"], due to the combining of default and
given argument, where before `values` would have been ["90"].

We were using arrays for both folder and value, which doesn't really
make sense since only the last positional argument can be variadic:
https://github.com/yargs/yargs/blob/master/docs/advanced.md#variadic-positional-arguments

Since we use comma-separated values, just use strings instead to avoid
the problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ⛓️ Pull requests that update a dependency package or file. infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants