Fix traverse script after yargs upgrade #11990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdn#11916 broke the traverse script, probably due to yargs/yargs#1992. The problem now is that for `npm run chrome all 90`, `values` will be ["null", "true", "90"], due to the combining of default and given argument, where before `values` would have been ["90"]. We were using arrays for both folder and value, which doesn't really make sense since only the last positional argument can be variadic: https://github.com/yargs/yargs/blob/master/docs/advanced.md#variadic-positional-arguments Since we use comma-separated values, just use strings instead to avoid the problem.
github-actions
bot
added
the
scripts 📜
lucalves
approved these changes
Aug 15, 2021
|
@ddbeck I think what we're doing is a bit weird, but I don't think it's worth making this change when nothing is broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11916 broke the traverse
script, probably due to yargs/yargs#1992.
The problem now is that for
npm run chrome all 90,valueswill be ["null", "true", "90"], due to the combining of default and
given argument, where before
valueswould have been ["90"].We were using arrays for both folder and value, which doesn't really
make sense since only the last positional argument can be variadic:
https://github.com/yargs/yargs/blob/master/docs/advanced.md#variadic-positional-arguments
Since we use comma-separated values, just use strings instead to avoid
the problem.