Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CryptoKeyPair dictionary from BCD #12346

Merged
merged 1 commit into from Sep 21, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR removes the CryptoKeyPair dictionary from BCD.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 11, 2021
@queengooborg queengooborg added needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation needs-release-note 📰 labels Sep 12, 2021
@foolip
Copy link
Collaborator

foolip commented Sep 13, 2021

mdn/content#8846 was closed without being merged, what does that mean for this PR?

@queengooborg
Copy link
Collaborator Author

As discussed in the content PR, the decision was to keep CryptoKeyPair as a separate entry in MDN, so we'll just be removing the compat table from the MDN page. We'll still be removing this from BCD!

Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's an open MDN PR for this yet, I'm approving but please land the MDN change before merging this.

@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Sep 21, 2021
@queengooborg
Copy link
Collaborator Author

Alright, this one's ready to go now!

@foolip foolip merged commit fd9c9cc into mdn:main Sep 21, 2021
@queengooborg queengooborg deleted the api/CryptoKeyPair branch September 21, 2021 07:26
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Sep 22, 2021
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Sep 22, 2021
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Sep 22, 2021
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Sep 22, 2021
ddbeck added a commit that referenced this pull request Sep 23, 2021
* Bump version to v4.0.5

* Bump known issues

* Add release note for #12417

* Add release note for #12454

* Add release note for #12417

* Add release note for #12346

* Add release note for #12455

* Add release note for #12518

* Add release note for #11630

* Add release note for #12300

* Add release note for #12552

* Add release stats

* Add release date

* Fix a typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants