Remove MutationObserverInit API from BCD #12795
Conversation
This PR removes `MutationObserverInit` from BCD. This feature is a dictionary, enum, or WebIDL typedef and should not be included in BCD.
queengooborg
added
needs-release-note 📰
needs content update 📝
github-actions
bot
added
the
data:api 🐇
queengooborg
removed
the
needs content update 📝
api/MutationObserver.json
Outdated
| }, | ||
| "firefox": { | ||
| "version_added": "14", | ||
| "notes": "Starting in Firefox 36, <code>attributeOldValue</code> has no default value; previously, its default value was <code>false</code>." |
There was a problem hiding this comment.
This and the other "Starting in Firefox 36" notes were added in #2299 with no discussion, and I don't think they make sense. A boolean dictionary member, even if it doesn't have a default value in the IDL, still almost certainly has a boolean default value internally in the C++ code. It is possible to handle a missing value differently as a 3rd state, but I doubt that was the case here.
https://bugzilla.mozilla.org/show_bug.cgi?id=973638 is marked as shipped in Firefox 36 and changes default values, so I think that's what this was about. That was matching https://www.w3.org/Bugs/Public/show_bug.cgi?id=23189, which actually seems to be exactly the same change as the "requires attributes: true" note for Edge.
http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=9713 is a test for this and I can confirm the issue in Edge 18 and Firefox 35, while it's fixed in Firefox 36. Can you test this to see if the problem was originally in Chrome and Firefox too? I assume it was.
I'm not sure this is worth a note or a separate partial_implementation entry, however. @Elchi3 WDYT?
There was a problem hiding this comment.
Thanks for writing a test! I found the same behavior until Chrome 33 and Safari 10.1, so I've updated the notes to reflect this. I've also folded the data into the observe() feature itself, since as you mentioned, the compatibility data is the same.
api/MutationObserver.json
Outdated
| @@ -225,40 +225,52 @@ | |||
| "spec_url": "https://dom.spec.whatwg.org/#ref-for-dom-mutationobserver-observe②", | |||
| "support": { | |||
| "chrome": { | |||
| "version_added": "18" | |||
| "version_added": "18", | |||
| "notes": "Before Chrome 33, <code>attributes: true</code> was required when using <code>attributeFilter</code> or <code>attributeOldValue</code>. If <code>attributes: true</code> is not present, then Chrome throws a syntax error." | |||
There was a problem hiding this comment.
| "notes": "Before Chrome 33, <code>attributes: true</code> was required when using <code>attributeFilter</code> or <code>attributeOldValue</code>. If <code>attributes: true</code> is not present, then Chrome throws a syntax error." | |
| "notes": "Before Chrome 33, <code>attributes: true</code> is required when using <code>attributeFilter</code> or <code>attributeOldValue</code>. If <code>attributes: true</code> is not present, then Chrome throws a syntax error." |
This PR removes `MutationObserverInit` from BCD. This feature is a dictionary, enum, or WebIDL typedef and should not be included in BCD. Update notes for attributeFilter parameter based upon testing.
* Bump version to v4.0.9 * Set release date * Add release note for #12795 * Add release note for #13006 * Add release note for #13136 * Add release note for #13076 * Add release note for #13216 * Add release note for #11924 * Add release note for #13143 * Undo list of one item * Hoist known issues * Add stats * Fix compare link
This PR removes
MutationObserverInitfrom BCD. This feature is a dictionary, enum, or WebIDL typedef and should not be included in BCD.