Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MutationObserverInit dictionary from MDN #9737

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Remove MutationObserverInit dictionary from MDN #9737

merged 3 commits into from
Oct 11, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR removes the MutationObserverInit dictionary from MDN. Corresponds with its removal in BCD, see mdn/browser-compat-data#12795.

@queengooborg queengooborg requested review from a team as code owners October 11, 2021 19:52
@queengooborg queengooborg requested review from wbamberg and removed request for a team October 11, 2021 19:52
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Oct 11, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2021

Preview URLs

Flaws

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/MutationRecord
Title: MutationRecord
on GitHub
Flaw count: 20

  • macros:
    • /en-US/docs/Web/API/MutationRecord/type does not exist
    • /en-US/docs/Web/API/MutationRecord/target does not exist
    • /en-US/docs/Web/API/MutationRecord/type does not exist
    • /en-US/docs/Web/API/MutationRecord/addedNodes does not exist
    • /en-US/docs/Web/API/MutationRecord/removedNodes does not exist
    • and 6 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 4 more flaws omitted

External URLs

URL: /en-US/docs/Web/API/MutationObserver/observe
Title: MutationObserver.observe()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/MutationRecord
Title: MutationRecord
on GitHub

No new external URLs


URL: /en-US/docs/Mozilla/Firefox/Releases/61
Title: Firefox 61 for developers
on GitHub

No new external URLs

(this comment was updated 2021-10-11 22:37:29.949473)

@hamishwillee
Copy link
Collaborator

@queengooborg Looks good as far as it goes. Are any of the examples in the remove attributes also worth copying into retained documents?

@queengooborg
Copy link
Collaborator Author

queengooborg commented Oct 11, 2021

I didn't think the examples were all too important to copy over, but it might be helpful to include the example from attributeFilter! I'll make the change now.

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that is good. Thanks very much.

@hamishwillee hamishwillee merged commit 0a22155 into mdn:main Oct 11, 2021
@queengooborg queengooborg deleted the MutationObserverInit branch October 11, 2021 23:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants