-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark console functions _static #20178
Conversation
I have slight preference for things in namespaces not to be marked as static (as the IDL does not mark them as static either and thus the parser doesn't give the flag, which means any tool would need to check the type of the parent). But I guess not marking it is again problematic for MDN, so I guess either way is fine. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but not merging until the content changes have been made.
This pull request has merge conflicts that must be resolved before it can be merged. |
* Mark console functions _static * Fix groupEnd --------- Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
So this feels a little weird but it updates the console data according to the discussion in #20114.