Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark console functions _static #20178

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Mark console functions _static #20178

merged 3 commits into from
Nov 14, 2023

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Jun 20, 2023

So this feels a little weird but it updates the console data according to the discussion in #20114.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 20, 2023
@Elchi3 Elchi3 added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jun 20, 2023
@saschanaz
Copy link
Contributor

I have slight preference for things in namespaces not to be marked as static (as the IDL does not mark them as static either and thus the parser doesn't give the flag, which means any tool would need to check the type of the parent). But I guess not marking it is again problematic for MDN, so I guess either way is fine. 😅

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but not merging until the content changes have been made.

@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Aug 7, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Sep 17, 2023
@Elchi3 Elchi3 removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Nov 14, 2023
@Elchi3 Elchi3 merged commit 27abec0 into mdn:main Nov 14, 2023
4 checks passed
@Elchi3 Elchi3 deleted the console-statics branch November 14, 2023 07:59
Elchi3 added a commit to Elchi3/browser-compat-data that referenced this pull request Nov 14, 2023
* Mark console functions _static

* Fix groupEnd

---------

Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants