Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark all console functions as static #30065

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Mark all console functions as static #30065

merged 1 commit into from
Nov 14, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR renames and moves all console function pages to mark them as static. Compliments BCD PR mdn/browser-compat-data#20178.

@queengooborg queengooborg requested review from a team as code owners November 6, 2023 11:37
@queengooborg queengooborg requested review from Elchi3 and removed request for a team November 6, 2023 11:37
@github-actions github-actions bot added the Content:WebAPI Web API docs label Nov 6, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Preview URLs (22 pages)
Flaws (65)

URL: /en-US/docs/Web/API/console/assert_static
Title: console: assert() static method
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_queries:
    • No BCD data for query: api.console.assert_static

URL: /en-US/docs/Web/API/console/warn_static
Title: console: warn() static method
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_queries:
    • No BCD data for query: api.console.warn_static

URL: /en-US/docs/Web/API/console/group_static
Title: console: group() static method
Flaw count: 4

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Console/groupEnd redirects to /en-US/docs/Web/API/console/groupend_static
    • /en-US/docs/Web/API/Console/groupEnd redirects to /en-US/docs/Web/API/console/groupend_static
  • bad_bcd_queries:
    • No BCD data for query: api.console.group_static

URL: /en-US/docs/Web/API/console/table_static
Title: console: table() static method
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_queries:
    • No BCD data for query: api.console.table_static

URL: /en-US/docs/Web/API/console/timestamp_static
Title: console: timeStamp() static method
Flaw count: 4

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Console/time redirects to /en-US/docs/Web/API/console/time_static
    • /en-US/docs/Web/API/Console/timeEnd redirects to /en-US/docs/Web/API/console/timeend_static
  • bad_bcd_queries:
    • No BCD data for query: api.console.timeStamp_static

URL: /en-US/docs/Web/API/console/log_static
Title: console: log() static method
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_queries:
    • No BCD data for query: api.console.log_static

URL: /en-US/docs/Web/API/console/dir_static
Title: console: dir() static method
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_queries:
    • No BCD data for query: api.console.dir_static

URL: /en-US/docs/Web/API/console/dirxml_static
Title: console: dirxml() static method
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_queries:
    • No BCD data for query: api.console.dirxml_static

URL: /en-US/docs/Web/API/console/info_static
Title: console: info() static method
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_queries:
    • No BCD data for query: api.console.info_static

URL: /en-US/docs/Web/API/console/countreset_static
Title: console: countReset() static method
Flaw count: 3

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Console/count redirects to /en-US/docs/Web/API/console/count_static
  • bad_bcd_queries:
    • No BCD data for query: api.console.countReset_static

URL: /en-US/docs/Web/API/console/error_static
Title: console: error() static method
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_queries:
    • No BCD data for query: api.console.error_static

URL: /en-US/docs/Web/API/console/timeend_static
Title: console: timeEnd() static method
Flaw count: 3

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Console/time redirects to /en-US/docs/Web/API/console/time_static
  • bad_bcd_queries:
    • No BCD data for query: api.console.timeEnd_static

URL: /en-US/docs/Web/API/console/clear_static
Title: console: clear() static method
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_queries:
    • No BCD data for query: api.console.clear_static

URL: /en-US/docs/Web/API/console/time_static
Title: console: time() static method
Flaw count: 6

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Console/timeEnd redirects to /en-US/docs/Web/API/console/timeend_static
    • /en-US/docs/Web/API/Console/timeEnd redirects to /en-US/docs/Web/API/console/timeend_static
    • /en-US/docs/Web/API/Console/timeEnd redirects to /en-US/docs/Web/API/console/timeend_static
    • /en-US/docs/Web/API/Console/timeLog redirects to /en-US/docs/Web/API/console/timelog_static
  • bad_bcd_queries:
    • No BCD data for query: api.console.time_static

URL: /en-US/docs/Web/API/console/profileend_static
Title: console: profileEnd() static method
Flaw count: 4

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Console/profile redirects to /en-US/docs/Web/API/console/profile_static
    • /en-US/docs/Web/API/Console/profile redirects to /en-US/docs/Web/API/console/profile_static
  • bad_bcd_queries:
    • No BCD data for query: api.console.profileEnd_static

URL: /en-US/docs/Web/API/console/timelog_static
Title: console: timeLog() static method
Flaw count: 4

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Console/time redirects to /en-US/docs/Web/API/console/time_static
    • /en-US/docs/Web/API/Console/time redirects to /en-US/docs/Web/API/console/time_static
  • bad_bcd_queries:
    • No BCD data for query: api.console.timeLog_static

URL: /en-US/docs/Web/API/console/profile_static
Title: console: profile() static method
Flaw count: 5

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Console/profileEnd redirects to /en-US/docs/Web/API/console/profileend_static
    • /en-US/docs/Web/API/Console/profileEnd redirects to /en-US/docs/Web/API/console/profileend_static
    • /en-US/docs/Web/API/Console/profileEnd redirects to /en-US/docs/Web/API/console/profileend_static
  • bad_bcd_queries:
    • No BCD data for query: api.console.profile_static

URL: /en-US/docs/Web/API/console/groupcollapsed_static
Title: console: groupCollapsed() static method
Flaw count: 4

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Console/group redirects to /en-US/docs/Web/API/console/group_static
    • /en-US/docs/Web/API/Console/groupEnd redirects to /en-US/docs/Web/API/console/groupend_static
  • bad_bcd_queries:
    • No BCD data for query: api.console.groupCollapsed_static

URL: /en-US/docs/Web/API/console/trace_static
Title: console: trace() static method
Flaw count: 3

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Console/log redirects to /en-US/docs/Web/API/console/log_static
  • bad_bcd_queries:
    • No BCD data for query: api.console.trace_static

URL: /en-US/docs/Web/API/console/count_static
Title: console: count() static method
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_queries:
    • No BCD data for query: api.console.count_static

URL: /en-US/docs/Web/API/console/debug_static
Title: console: debug() static method
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_queries:
    • No BCD data for query: api.console.debug_static

URL: /en-US/docs/Web/API/console/groupend_static
Title: console: groupEnd() static method
Flaw count: 3

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Console/group redirects to /en-US/docs/Web/API/console/group_static
  • bad_bcd_queries:
    • No BCD data for query: api.console.groupEnd_static

Elchi3
Elchi3 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked around again if there is consensus to go ahead and move these to statics and I think there is. Other namespaces like CSS (https://developer.mozilla.org/en-US/docs/Web/API/CSS) also use static for their members. So LGTM.

@Elchi3 Elchi3 merged commit cdb0dad into main Nov 14, 2023
7 checks passed
@Elchi3 Elchi3 deleted the console_static branch November 14, 2023 07:58
@mdn mdn deleted a comment from Yobb17 Nov 14, 2023
yin1999 added a commit to mdn/translated-content that referenced this pull request Nov 15, 2023
@yin1999
zh-cn: sync upstream changes
1b3a21f 
ref: mdn/content#30065
yin1999 added a commit to mdn/translated-content that referenced this pull request Nov 15, 2023
@mdn-bot @yin1999
[zh-cn] sync translated content (#16975)
b95aeed 
* zh-cn: sync translated content

* zh-cn: sync upstream changes

ref: mdn/content#30065

---------

Co-authored-by: Allo <yin199909@aliyun.com>
@SphinxKnight SphinxKnight mentioned this pull request Nov 24, 2023
Merged
teoli2003 pushed a commit that referenced this pull request Nov 24, 2023
@SphinxKnight
Fix: nits and improvements for console pages - follow-up of #30065 (#…
2288418 
…30502)

* Remove MSDN ref/links - homogenize See also

* Reword 'web console' to 'console' since this also applies to server runtimes

* newline confusion

* another web/browser console ref

* Alt text supposed to be useful

* Consistency is not optional

* Old stories

* Static and backticks

* Consistency once again

* Typo

* Consistency but static
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@queengooborg @Elchi3