Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mdn-bcd-collector update script's ua-parser alone #20210

Closed
wants to merge 3 commits into from
Closed

Add mdn-bcd-collector update script's ua-parser alone #20210

wants to merge 3 commits into from

Conversation

mzgoddard
Copy link
Contributor

@mzgoddard mzgoddard commented Jun 22, 2023 •
edited
Loading

Summary

Add the ua-parser library from mdn-bcd-collector.

Test results and supporting details

Includes tests from mdn-bcd-collector for the library.

This file includes applied requested changes from #19971. (I don't recall anything other than the license comment.)

Related issues

To help reduce potential for merge conflicts, we may want to split this down into even smaller chunks. For example, the UA parser I think could be its own PR (and I have some change requests regarding it specifically that would help turn it into a useful utility).

Originally posted by @queengooborg in #19971 (comment)

@github-actions github-actions bot added dependencies ⛓️ Pull requests that update a dependency package or file. infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. labels Jun 22, 2023
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@foolip foolip mentioned this pull request Jun 29, 2023
Merged
@foolip foolip requested a review from queengooborg June 29, 2023 17:06
@foolip
Copy link
Collaborator

foolip commented Jun 29, 2023

@mzgoddard with #19971 merged, is there anything left of this PR that should be landed?

@mzgoddard
Copy link
Contributor Author

@foolip Yeah I think we can close this with #19971 merged.

@mzgoddard mzgoddard closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg Awaiting requested review from queengooborg

Assignees
No one assigned
Labels
dependencies ⛓️ Pull requests that update a dependency package or file. infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzgoddard @foolip