Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser_style:true removed from MV3 #20480

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

rebloor
Copy link
Collaborator

@rebloor rebloor commented Aug 5, 2023

Description

Updated relevant notes to indicate that 'browser_style:true' removed from MV3 in release 118.

Related issues and pull requests

Provide documentation for Bug 1830711 Turn off support for browser_style:true in MV3
Content changes made in #28415

@rebloor rebloor added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Aug 5, 2023
@rebloor rebloor requested a review from Rob--W August 5, 2023 18:01
@rebloor rebloor self-assigned this Aug 5, 2023
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -49,8 +49,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": "48",
"notes": "Deprecated in Manifest V3. See <a href='https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/user_interface/Browser_styles'>Browser styles</a> for more details."
"version_added": "48"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version_added": "48"
"version_added": "48",
"notes": "Removed from Manifest V3 in Firefox 118. See <a href='https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/user_interface/Browser_styles'>Browser styles</a> for more details."

This note should be kept.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, never mind. browser_action is MV2-only.

@rebloor rebloor merged commit f484e88 into mdn:main Aug 8, 2023
3 checks passed
@rebloor rebloor deleted the browser_style-true-in-MV3 branch August 8, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants