Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser_style:true removed from MV3 #28415

Merged
merged 4 commits into from Aug 27, 2023
Merged

browser_style:true removed from MV3 #28415

merged 4 commits into from Aug 27, 2023

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Aug 5, 2023 •
edited

Description

Add a release note to indicate that 'browser_style:true' removed from MV3 in release 118.

Related issues and pull requests

Provide documentation for Bug 1830711 Turn off support for browser_style:true in MV3
Related browser compatibility data changes in #20480

@rebloor rebloor added the Content:WebExt WebExtensions docs label Aug 5, 2023
@rebloor rebloor requested a review from Rob--W August 5, 2023 17:42
@rebloor rebloor self-assigned this Aug 5, 2023
@rebloor rebloor requested a review from a team as a code owner August 5, 2023 17:42
@rebloor rebloor requested review from hamishwillee and removed request for a team August 5, 2023 17:42
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree and removed Content:WebExt WebExtensions docs labels Aug 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023 •
edited

Preview URLs (6 pages)
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/118
Title: Firefox 118 for developers

(comment last updated: 2023-08-27 17:06:31)

@rebloor rebloor mentioned this pull request Aug 5, 2023
Merged
@rebloor
Copy link
Contributor Author

rebloor commented Aug 5, 2023

@Rob--W are you happy to change the references on the manifest key files from "support will be removed in Firefox 118." to "support removed in Firefox 118." or do that on 26 September?

@hamishwillee hamishwillee removed their request for review August 8, 2023 00:26
Rob--W
Rob--W approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. There are still references in the future tense like "will be removed in Firefox 118", added in #26642. Do you want to rephrase these before merging?

@rebloor rebloor requested a review from a team as a code owner August 9, 2023 00:01
@github-actions github-actions bot added the Content:WebExt WebExtensions docs label Aug 9, 2023
@rebloor
Copy link
Contributor Author

rebloor commented Aug 9, 2023

@Rob--W thanks for answering my question, although I think you missed it.

Rob--W
Rob--W reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge after fixing the English issue.

files/en-us/mozilla/add-ons/webextensions/manifest.json/action/index.md Outdated Show resolved Hide resolved
files/en-us/mozilla/firefox/releases/118/index.md Outdated Show resolved Hide resolved
@rebloor @Rob--W
Apply suggestions from review
7ad1f2d 
Co-authored-by: Rob Wu <rob@robwu.nl>
@rebloor rebloor merged commit 0364790 into mdn:main Aug 27, 2023
6 checks passed
@rebloor rebloor deleted the browser_style-true-in-MV3 branch August 27, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob--W Rob--W Rob--W approved these changes

Assignees

@rebloor rebloor

Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:WebExt WebExtensions docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rebloor @Rob--W