-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
html.img: Remove phantom onerror deprecation #21783
Conversation
The `onerror` attribute to the `img` element has been marked deprecated since the table data was introduced in 061483a. However, that deprecation was never sourced to any specs or references, and multiple inquiries since have failed to uncover any explanation for it. It appears to have been a simple error.
I think the current rule is not to list Let's double-check this with @queengooborg or @Elchi3. |
Actually, the rule is not to document event handler attributes on the interface, not the HTML attribute. For the most part, I think we've been keeping the HTML attributes for event handlers? |
Another data point:
This is in contrast to every other attribute marked as deprecated in the chart data, which are all gathered together in § Deprecated Attributes of the article. |
In that case, we have 100s of "onXYZ" missing on elements. For example, |
It's possible the idea was that the compatibility chart should provide information on whatever's discussed in the article. Like I said, Personally it doesn't matter to me whether it gets removed or fixed. I just want to stop claiming it's deprecated when it's not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is useful to have all the event handlers in the HTML compat data, so this data might get removed, but for now the PR is correct as it stands. The onerror
event handler is not deprecated.
Summary
This PR removes the deprecation annotation from the
onerror
attribute of the HTMLimg
tag's browser compatibility data.Test results and supporting details
api.HtmlImageElement
reference regarding error-handling, in Fixes to api.HTMLImageElement #4724Original source of existing data
Related issues
Commit message body
The
onerror
attribute to theimg
element has been marked deprecated since the table data was introduced in 061483a. However, that deprecation was never sourced to any specs or references, and multiple inquiries since have failed to uncover any explanation for it. It appears to have been a simple error.