Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome support for webextensions.action.openpopup correction #22268

Merged

Conversation

rebloor
Copy link
Collaborator

@rebloor rebloor commented Feb 21, 2024

Summary

This fixes an error made in #22148, which updated browserAction not action compatibility data. Fixes #16442

@rebloor rebloor added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Feb 21, 2024
@rebloor rebloor self-assigned this Feb 21, 2024
"value_to_set": "Enabled"
}
]
"version_added": "118"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API is still not available by default, so it should still be marked as experimental: #16442 (comment)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rob--W according to the schema, and the linter, you can only mark an API as experimental at the API level, not the browser. Therefore, added a note instead.

@rebloor rebloor requested a review from Rob--W February 22, 2024 09:04
@rebloor rebloor merged commit 1b1913b into mdn:main Feb 22, 2024
6 checks passed
@rebloor rebloor deleted the Chrome-support-for-webextensions.action.openpopup2 branch February 22, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Chrome support for chrome.action.openPopup()
2 participants