Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing features for appearance CSS property #22546

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

queengooborg
Copy link
Collaborator

This PR adds the missing features of the appearance CSS property. The data comes from the mdn-bcd-collector project (v10.9.0).

Check out the collector's guide on how to review this PR.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/appearance

This PR adds the missing features of the `appearance` CSS property. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.9.0).

_Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/appearance
@queengooborg queengooborg added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Mar 5, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break references made in web-platform-dx/web-features#634 cc @foolip

I think we can follow up with a fix to web-features (or we use tags, or we do both).

@queengooborg
Copy link
Collaborator Author

The idea of using web-features tags is to eliminate the need for WebDX to define all the BCD keys manually, is that correct? Tags sounds like the right call here!

@Elchi3
Copy link
Member

Elchi3 commented Mar 6, 2024

The idea of using web-features tags is to eliminate the need for WebDX to define all the BCD keys manually, is that correct?

Yes, that was the whole reason I wanted tags! :)

@foolip
Copy link
Collaborator

foolip commented Mar 6, 2024

This will break references made in web-platform-dx/web-features#634 cc @foolip

I think we can follow up with a fix to web-features (or we use tags, or we do both).

Feel free to break web-features references. They'll all come to light when we compute Baseline status from BCD, and I can fix things then. If you want to fix things proactively that's nice, but I don't want web-features to slow down BCD maintenance.

@queengooborg
Copy link
Collaborator Author

I've added a tag with the name matching the feature group, so that should help!

@Elchi3 Elchi3 merged commit 9ac02fa into mdn:main Mar 6, 2024
6 checks passed
@queengooborg queengooborg deleted the css/properties/appearance/additions branch March 6, 2024 11:14
foolip added a commit to foolip/web-features that referenced this pull request Apr 5, 2024
One has been removed:
mdn/browser-compat-data#22546

The others look like typos.
foolip added a commit to web-platform-dx/web-features that referenced this pull request Apr 6, 2024
One has been removed:
mdn/browser-compat-data#22546

The others look like typos.
Elchi3 pushed a commit to web-platform-dx/web-features that referenced this pull request Apr 8, 2024
One has been removed:
mdn/browser-compat-data#22546

The others look like typos.
elarteteatrallz added a commit to elarteteatrallz/web-features that referenced this pull request Aug 17, 2024
One has been removed:
mdn/browser-compat-data#22546

The others look like typos.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants