-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing features for appearance CSS property #22546
Add missing features for appearance CSS property #22546
Conversation
This PR adds the missing features of the `appearance` CSS property. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.9.0). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/appearance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break references made in web-platform-dx/web-features#634 cc @foolip
I think we can follow up with a fix to web-features (or we use tags, or we do both).
The idea of using web-features tags is to eliminate the need for WebDX to define all the BCD keys manually, is that correct? Tags sounds like the right call here! |
Yes, that was the whole reason I wanted tags! :) |
Feel free to break web-features references. They'll all come to light when we compute Baseline status from BCD, and I can fix things then. If you want to fix things proactively that's nice, but I don't want web-features to slow down BCD maintenance. |
I've added a tag with the name matching the feature group, so that should help! |
One has been removed: mdn/browser-compat-data#22546 The others look like typos.
One has been removed: mdn/browser-compat-data#22546 The others look like typos.
One has been removed: mdn/browser-compat-data#22546 The others look like typos.
One has been removed: mdn/browser-compat-data#22546 The others look like typos.
This PR adds the missing features of the
appearance
CSS property. The data comes from the mdn-bcd-collector project (v10.9.0).Check out the collector's guide on how to review this PR.
Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/appearance