-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API/StorageManager: add compat data #2272
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,35 +4,54 @@ | |
"__compat": { | ||
"mdn_url": "https://developer.mozilla.org/docs/Web/API/StorageManager", | ||
"support": { | ||
"webview_android": { | ||
"version_added": null | ||
}, | ||
"chrome": { | ||
"version_added": null | ||
"version_added": "48" | ||
}, | ||
"chrome_android": { | ||
"version_added": null | ||
"version_added": "48" | ||
}, | ||
"edge": { | ||
"version_added": null | ||
}, | ||
"edge_mobile": { | ||
"version_added": null | ||
}, | ||
"firefox": { | ||
"version_added": null | ||
}, | ||
"firefox": [ | ||
{ | ||
"version_added": "57" | ||
}, | ||
{ | ||
"version_added": "51", | ||
"version_removed": "57", | ||
"notes": "See <a href='https://bugzil.la/1304966'>bug 1304966</a> and <a href='https://bugzil.la/1399038'>bug 1399038</a>.", | ||
"flags": [ | ||
{ | ||
"type": "preference", | ||
"name": "dom.storageManager.enabled", | ||
"value_to_set": "true" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. MDN stated that, from version 55, the preference |
||
} | ||
] | ||
} | ||
], | ||
"firefox_android": { | ||
"version_added": null | ||
"version_added": "51", | ||
"notes": "See <a href='https://bugzil.la/1304966'>bug 1304966</a> and <a href='https://bugzil.la/1399038'>bug 1399038</a>.", | ||
"flags": [ | ||
{ | ||
"type": "preference", | ||
"name": "dom.storageManager.enabled", | ||
"value_to_set": "true" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. MDN did not mention yet that the feature is still be behind a flag on Android: |
||
} | ||
] | ||
}, | ||
"ie": { | ||
"version_added": null | ||
}, | ||
"opera": { | ||
"version_added": null | ||
"version_added": true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since I updated the Chrome versions and am not aware of a Chrome version to Opera version mapping (like [the one for Samsung Internet]), I have reset these versions to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Opera is usually Chrome - 13, so in this case 35. But I've always been a little bit uncomfortable doing that on an automatic basis, so you don't actually have to change this. I'll leave it up to your judgment |
||
}, | ||
"opera_android": { | ||
"version_added": null | ||
"version_added": true | ||
}, | ||
"safari": { | ||
"version_added": null | ||
|
@@ -42,6 +61,9 @@ | |
}, | ||
"samsunginternet_android": { | ||
"version_added": null | ||
}, | ||
"webview_android": { | ||
"version_added": "48" | ||
} | ||
}, | ||
"status": { | ||
|
@@ -54,14 +76,11 @@ | |
"__compat": { | ||
"mdn_url": "https://developer.mozilla.org/docs/Web/API/StorageManager/estimate", | ||
"support": { | ||
"webview_android": { | ||
"version_added": null | ||
}, | ||
"chrome": { | ||
"version_added": null | ||
"version_added": "52" | ||
}, | ||
"chrome_android": { | ||
"version_added": null | ||
"version_added": "52" | ||
}, | ||
"edge": { | ||
"version_added": null | ||
|
@@ -70,19 +89,19 @@ | |
"version_added": null | ||
}, | ||
"firefox": { | ||
"version_added": null | ||
"version_added": "51" | ||
}, | ||
"firefox_android": { | ||
"version_added": null | ||
"version_added": "51" | ||
}, | ||
"ie": { | ||
"version_added": null | ||
}, | ||
"opera": { | ||
"version_added": null | ||
"version_added": true | ||
}, | ||
"opera_android": { | ||
"version_added": null | ||
"version_added": true | ||
}, | ||
"safari": { | ||
"version_added": null | ||
|
@@ -92,6 +111,9 @@ | |
}, | ||
"samsunginternet_android": { | ||
"version_added": null | ||
}, | ||
"webview_android": { | ||
"version_added": "52" | ||
} | ||
}, | ||
"status": { | ||
|
@@ -105,35 +127,46 @@ | |
"__compat": { | ||
"mdn_url": "https://developer.mozilla.org/docs/Web/API/StorageManager/persist", | ||
"support": { | ||
"webview_android": { | ||
"version_added": null | ||
}, | ||
"chrome": { | ||
"version_added": null | ||
}, | ||
"chrome_android": { | ||
"version_added": null | ||
}, | ||
"chrome": [ | ||
{ | ||
"version_added": "52" | ||
}, | ||
{ | ||
"alternative_name": "requestPersistend", | ||
"version_added": "48", | ||
"version_removed": "52" | ||
} | ||
], | ||
"chrome_android": [ | ||
{ | ||
"version_added": "52" | ||
}, | ||
{ | ||
"alternative_name": "requestPersistend", | ||
"version_added": "48", | ||
"version_removed": "52" | ||
} | ||
], | ||
"edge": { | ||
"version_added": null | ||
}, | ||
"edge_mobile": { | ||
"version_added": null | ||
}, | ||
"firefox": { | ||
"version_added": null | ||
"version_added": "55" | ||
}, | ||
"firefox_android": { | ||
"version_added": null | ||
"version_added": "55" | ||
}, | ||
"ie": { | ||
"version_added": null | ||
}, | ||
"opera": { | ||
"version_added": null | ||
"version_added": true | ||
}, | ||
"opera_android": { | ||
"version_added": null | ||
"version_added": true | ||
}, | ||
"safari": { | ||
"version_added": null | ||
|
@@ -143,7 +176,17 @@ | |
}, | ||
"samsunginternet_android": { | ||
"version_added": null | ||
} | ||
}, | ||
"webview_android": [ | ||
{ | ||
"version_added": "52" | ||
}, | ||
{ | ||
"alternative_name": "requestPersistend", | ||
"version_added": "48", | ||
"version_removed": "52" | ||
} | ||
] | ||
}, | ||
"status": { | ||
"experimental": false, | ||
|
@@ -156,35 +199,46 @@ | |
"__compat": { | ||
"mdn_url": "https://developer.mozilla.org/docs/Web/API/StorageManager/persisted", | ||
"support": { | ||
"webview_android": { | ||
"version_added": null | ||
}, | ||
"chrome": { | ||
"version_added": null | ||
}, | ||
"chrome_android": { | ||
"version_added": null | ||
}, | ||
"chrome": [ | ||
{ | ||
"version_added": "52" | ||
}, | ||
{ | ||
"alternative_name": "persistentPermission", | ||
"version_added": "48", | ||
"version_removed": "52" | ||
} | ||
], | ||
"chrome_android": [ | ||
{ | ||
"version_added": "52" | ||
}, | ||
{ | ||
"alternative_name": "requestPersistend", | ||
"version_added": "48", | ||
"version_removed": "52" | ||
} | ||
], | ||
"edge": { | ||
"version_added": null | ||
}, | ||
"edge_mobile": { | ||
"version_added": null | ||
}, | ||
"firefox": { | ||
"version_added": null | ||
"version_added": "55" | ||
}, | ||
"firefox_android": { | ||
"version_added": null | ||
"version_added": "55" | ||
}, | ||
"ie": { | ||
"version_added": null | ||
}, | ||
"opera": { | ||
"version_added": null | ||
"version_added": true | ||
}, | ||
"opera_android": { | ||
"version_added": null | ||
"version_added": true | ||
}, | ||
"safari": { | ||
"version_added": null | ||
|
@@ -194,7 +248,17 @@ | |
}, | ||
"samsunginternet_android": { | ||
"version_added": null | ||
} | ||
}, | ||
"webview_android": [ | ||
{ | ||
"version_added": "52" | ||
}, | ||
{ | ||
"alternative_name": "persistentPermission", | ||
"version_added": "48", | ||
"version_removed": "52" | ||
} | ||
] | ||
}, | ||
"status": { | ||
"experimental": false, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, I have added the compat data despite the ongoing discussion in #190 about representing the "secure context" requirement.
In my opinion, a browser could be considered compatible if it offers the feature in the secure context as defined by the spec. On the other hand, I wouldn't consider a browser incompatible, if it also offers the feature outside of the [required] secure context, but instead point this out in a
"notes"
entry.