Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API/StorageManager: add compat data #2272

Merged
merged 3 commits into from
Jul 20, 2018
Merged

API/StorageManager: add compat data #2272

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d02ee76
API/StorageManager: add compat data
caugner Jun 9, 2018
274f8ab
StorageManager: fix bug capitalization
caugner Jul 20, 2018
4125b1a
StorageManager: sort status
caugner Jul 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
148 changes: 106 additions & 42 deletions api/StorageManager.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,34 +5,56 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/API/StorageManager",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, I have added the compat data despite the ongoing discussion in #190 about representing the "secure context" requirement.

In my opinion, a browser could be considered compatible if it offers the feature in the secure context as defined by the spec. On the other hand, I wouldn't consider a browser incompatible, if it also offers the feature outside of the [required] secure context, but instead point this out in a "notes" entry.

"support": {
"webview_android": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I've suggested other changes, may as well sort the browsers too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I just did that in 4125b1a.

"version_added": null
"version_added": "48"
},
"chrome": {
"version_added": null
"version_added": "48"
Copy link
Contributor Author

@caugner caugner Jun 9, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MDN stated 55, but basic and full support was already established in 48 and 52 respectively:

},
"chrome_android": {
"version_added": null
"version_added": "48"
},
"edge": {
"version_added": null
},
"edge_mobile": {
"version_added": null
},
"firefox": {
"version_added": null
},
"firefox": [
{
"version_added": "57"
},
{
"version_added": "51",
"version_removed": "57",
"notes": "See <a href='https://bugzil.la/1304966'>Bug 1304966</a> and <a href='https://bugzil.la/1399038'>Bug 1399038</a>.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we routinely capitalize "bug"

Copy link
Contributor Author

@caugner caugner Jul 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just that in 274f8ab and added issue #2509 to potentially check this as part of linting.

"flags": [
{
"type": "preference",
"name": "dom.storageManager.enabled",
"value_to_set": "true"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MDN stated that, from version 55, the preference browser.storageManager.enabled was also required, but I found no evidence for this (neither in the repository nor in the bugs).

}
]
}
],
"firefox_android": {
"version_added": null
"version_added": "51",
"notes": "See <a href='https://bugzil.la/1304966'>Bug 1304966</a> and <a href='https://bugzil.la/1399038'>Bug 1399038</a>.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug capitalization here too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

"flags": [
{
"type": "preference",
"name": "dom.storageManager.enabled",
"value_to_set": "true"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MDN did not mention yet that the feature is still be behind a flag on Android:
https://github.com/mozilla/gecko-dev/blob/04b9cbbc2be2137a37e158a5ebaf9c7bef2364f9/modules/libpref/init/all.js#L5723-L5727

}
]
},
"ie": {
"version_added": null
},
"opera": {
"version_added": null
"version_added": true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I updated the Chrome versions and am not aware of a Chrome version to Opera version mapping (like [the one for Samsung Internet]), I have reset these versions to true.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opera is usually Chrome - 13, so in this case 35. But I've always been a little bit uncomfortable doing that on an automatic basis, so you don't actually have to change this. I'll leave it up to your judgment

},
"opera_android": {
"version_added": null
"version_added": true
},
"safari": {
"version_added": null
Expand All @@ -55,13 +77,13 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/API/StorageManager/estimate",
"support": {
"webview_android": {
"version_added": null
"version_added": "52"
},
"chrome": {
"version_added": null
"version_added": "52"
},
"chrome_android": {
"version_added": null
"version_added": "52"
},
"edge": {
"version_added": null
Expand All @@ -70,19 +92,19 @@
"version_added": null
},
"firefox": {
"version_added": null
"version_added": "51"
},
"firefox_android": {
"version_added": null
"version_added": "51"
},
"ie": {
"version_added": null
},
"opera": {
"version_added": null
"version_added": true
},
"opera_android": {
"version_added": null
"version_added": true
},
"safari": {
"version_added": null
Expand All @@ -105,35 +127,56 @@
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/StorageManager/persist",
"support": {
"webview_android": {
"version_added": null
},
"chrome": {
"version_added": null
},
"chrome_android": {
"version_added": null
},
"webview_android": [
{
"version_added": "52"
},
{
"alternative_name": "requestPersistend",
"version_added": "48",
"version_removed": "52"
}
],
"chrome": [
{
"version_added": "52"
},
{
"alternative_name": "requestPersistend",
"version_added": "48",
"version_removed": "52"
}
],
"chrome_android": [
{
"version_added": "52"
},
{
"alternative_name": "requestPersistend",
"version_added": "48",
"version_removed": "52"
}
],
"edge": {
"version_added": null
},
"edge_mobile": {
"version_added": null
},
"firefox": {
"version_added": null
"version_added": "55"
},
"firefox_android": {
"version_added": null
"version_added": "55"
},
"ie": {
"version_added": null
},
"opera": {
"version_added": null
"version_added": true
},
"opera_android": {
"version_added": null
"version_added": true
},
"safari": {
"version_added": null
Expand All @@ -156,35 +199,56 @@
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/StorageManager/persisted",
"support": {
"webview_android": {
"version_added": null
},
"chrome": {
"version_added": null
},
"chrome_android": {
"version_added": null
},
"webview_android": [
{
"version_added": "52"
},
{
"alternative_name": "persistentPermission",
"version_added": "48",
"version_removed": "52"
}
],
"chrome": [
{
"version_added": "52"
},
{
"alternative_name": "persistentPermission",
"version_added": "48",
"version_removed": "52"
}
],
"chrome_android": [
{
"version_added": "52"
},
{
"alternative_name": "requestPersistend",
"version_added": "48",
"version_removed": "52"
}
],
"edge": {
"version_added": null
},
"edge_mobile": {
"version_added": null
},
"firefox": {
"version_added": null
"version_added": "55"
},
"firefox_android": {
"version_added": null
"version_added": "55"
},
"ie": {
"version_added": null
},
"opera": {
"version_added": null
"version_added": true
},
"opera_android": {
"version_added": null
"version_added": true
},
"safari": {
"version_added": null
Expand Down