Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chromium data for optional_permissions Web Extensions manifest property #24093

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Aug 10, 2024

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the optional_permissions Web Extensions manifest property. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing true values with ranged values to eliminate true values from BCD.

Commit/PR Adding the Feature: #1673, #1771, #5840, #6112, #12155

Edit: this PR now uses the source code and commit history of Chrome to add specific version numbers, rather than just ranges. Details for each feature and the commit the version number chosen is available in the commit messages for this PR.

… property

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `optional_permissions` Web Extensions manifest property. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing `true` values with ranged values to eliminate `true` values from BCD.

Commit/PR Adding the Feature: mdn#1673, mdn#1771, mdn#5840, mdn#6112, mdn#12155
@queengooborg queengooborg added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Aug 10, 2024
Commit: https://chromium.googlesource.com/chromium/src/+/006236a292a8dec7b134b3db35bc1d9ea7767513
Commit Date: February 24, 2012
Chrome 19 Feature Freeze: March 9, 2012
Commit: https://chromium.googlesource.com/chromium/src/+/b62972dac61add19354116b5549ba624b982f14f
Commit Date: June 21, 2012
Chrome 22 Feature Freeze: July 20, 2012
Commit: https://chromium.googlesource.com/chromium/src/+/607e6522f841933e0d3130c09d33207876850948
Commit Date: January 25, 2012
Chrome 19 Feature Freeze: March 9, 2012
Commit: https://chromium.googlesource.com/chromium/src/+/641bdeb0830b56bd715699126176cc750c10fb92
Commit Date: March 22, 2012
Chrome 20 Feature Freeze: April 20, 2012
Commit: https://source.chromium.org/chromium/chromium/src/+/d791ad1ba1cd9246b83ecf3a8622006706fb9605
Commit Date: August 22, 2013
Chrome 31 Feature Freeze: September 6, 2013
Commit: https://chromium.googlesource.com/chromium/src/+/d9c1ade4d29daf457cadbfdf15c71e92e5ffeebb
Commit Date: January 9, 2012
Chrome 18 Feature Freeze: January 13, 2012
Commit: https://source.chromium.org/chromium/chromium/src/+/2b41a696076298ceaaf1d74e01d7c38511852bbf
Commit Date: January 22, 2012
Chrome 19 Feature Freeze: March 9, 2012
@queengooborg queengooborg added the KR: Real BCD 🔑 Key Result: Eliminate true/null values and replace them with "real" values. label Sep 3, 2024
@queengooborg
Copy link
Collaborator Author

I've now tagged all of the PRs that remove "true" and "null" with the "KR: Real Values" tag. @rebloor, if you could prioritize reviewing those PRs over the other ones I've opened (and am opening), that would be most appreciated!

@rebloor
Copy link
Collaborator

rebloor commented Sep 4, 2024

@queengooborg could you explain your sources? For example, why is nativeMessaging marked as Chrome 27. (The only reference here is to a Firefox related PR.)

@queengooborg
Copy link
Collaborator Author

The commits for each of the features have the infomation for the sources used -- check each commit to find out more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions KR: Real BCD 🔑 Key Result: Eliminate true/null values and replace them with "real" values.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants