Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug1067769 KeyframeEffect.target on Firefox #2441

Closed

Conversation

a2sheppy
Copy link
Contributor

@a2sheppy a2sheppy commented Jul 9, 2018

This was added to Firefox in version 49.

Eric Shepherd (:sheppy) added 2 commits July 9, 2018 18:32
Added version 62 for both Firefox and FxAndroid for the
KeyframeEffect.target property.
pop up under "Update docs for Firefox 62" :)
@birtles
Copy link
Contributor

birtles commented Jul 9, 2018

We're not shipping yet though. Probably in 63.

@Elchi3 Elchi3 added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 10, 2018
@a2sheppy
Copy link
Contributor Author

@birtles Is it in but preffed off in 62, or has it been removed?

@birtles
Copy link
Contributor

birtles commented Jul 10, 2018

Yes, it's preffed off (like most of the API).

We've agreed with Google on a couple of occasions (both with their animation folk and MDN folk) not to mark features in this API as supported if they are preffed off in release, partly because a lot of these features landed in a fairly incomplete state behind a flags and have changed a few times since so it's hard to say when it was supported..

@a2sheppy
Copy link
Contributor Author

Good to know. I had not heard about that agreement, and this issue was on our changelist for Firefox 62, so it got done. I will withdraw this patch.

@a2sheppy a2sheppy closed this Jul 10, 2018
@birtles
Copy link
Contributor

birtles commented Jul 11, 2018

Yes, sorry about that. The animation folk involved in that discussion have since moved on so we can revisit that approach if need be.

@Elchi3 Elchi3 added invalid 🚫 Invalid issues or pull requests (wrong repo, spam, duplicates, etc.). This won't get merged. Sorry! and removed data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API labels Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid 🚫 Invalid issues or pull requests (wrong repo, spam, duplicates, etc.). This won't get merged. Sorry!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants