Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing compatiblity information to windows API #262

Merged
merged 1 commit into from
Jun 21, 2017
Merged

Added missing compatiblity information to windows API #262

merged 1 commit into from
Jun 21, 2017

Conversation

snoack
Copy link
Contributor

@snoack snoack commented Jun 19, 2017

I added missing compatibility information for following API features:

  • CreateType
    • detached_panel is specific to Firefox (i.e. not supported in Chrome, Opera and Edge).
    • panel is not supported in Microsoft Edge.
  • WINDOW_ID_CURRENT
  • Window.alwaysOnTop
  • Window.sessionId
    • Added in Chrome 31 according to their documentation (respectively Opera 18).
    • It does not exist on Firefox and Microsoft Edge.
  • WindowState
    • minimized, maximized and fullscreen do not exist in Microsoft Edge according to their documentation.
    • docked does only exist in Chrome/Opera and is deprecated there.
  • WindowType
  • windows.create() options
  • windows.get(), windows.getCurrent() and windows.getLastFocused() options
    • getInfo was added in Chrome 18 according to their documentation (respectively Opera 15).
    • getInfo.windowTypes was added in Chrome 46 according to their documentation (respectively Opera 33).
  • windows.getAll() options
    • populate is not supported in Microsoft Edge according to their documentation.
    • windowTypes was added in Chrome 46 according to their documentation (respectively Opera 33).
  • windows.update() options
    • left, top and drawAttention are not supported in Microsoft Edge according to their documentation.

@Elchi3 Elchi3 added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Jun 20, 2017
@snoack
Copy link
Contributor Author

snoack commented Jun 20, 2017

Rebased on top of #263. Please merge #263 first.

@snoack
Copy link
Contributor Author

snoack commented Jun 21, 2017

Rebased (on top of master).

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@wbamberg wbamberg merged commit e421c3d into mdn:master Jun 21, 2017
@snoack snoack deleted the windows branch September 15, 2017 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants