Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1496961: Unship ‑moz‑box display values on release channels #2974

Merged
merged 2 commits into from
Oct 16, 2018

Conversation

ExE-Boss
Copy link
Contributor

See bug 1496961 for details.

review?(@Elchi3)

@Elchi3 Elchi3 added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Oct 15, 2018
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you PR! I have a suggestion for the note. LGTM otherwise.

I'm not sure how useful the flag information from Firefox 62 onwards is for anyone, but we can keep those in for completeness sake. I can imagine that we will remove XUL features from BCD/MDN after a year (or so) of them being unshipped for the web as they are not relevant to web developers anymore. Probably still a bit early, but I'd like to see these things go away from our docs at some point.

{
"version_added": true,
"version_removed": "64",
"notes": "This is still available to Firefox UI code"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change these notes to "Still available in Firefox UI code."
Notes should end with a full stop. (we should probably document this requirement)

@ExE-Boss
Copy link
Contributor Author

Maybe not remove them from MDN, as MDN also contains Mozilla specific information, but move them all under the /docs/Mozilla internal tree.

@Elchi3
Copy link
Member

Elchi3 commented Oct 15, 2018

Well, we could possibly move this, but in the future MDN Web docs will not be about Mozilla specific information anymore, see https://blog.mozilla.org/opendesign/future-mdn-focus-web-docs/ and XUL is dying.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit b1bd462 into mdn:master Oct 16, 2018
@ExE-Boss ExE-Boss deleted the css/properties/display branch October 16, 2018 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants