Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opera still supports @keyframes #3227

Merged
merged 2 commits into from
Dec 21, 2018
Merged

Opera still supports @keyframes #3227

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a44908c
Opera still supports @keyframes
antross Dec 18, 2018
b44a576
Include history of support changes
antross Dec 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions css/at-rules/keyframes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@
},
"opera": [
{
"version_added": "12.1",
"version_removed": "15"
"version_added": "12.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the data here isn't quite wrong, but it's definitely not complete. It looks like, in the transition from Presto to Blink, Opera did indeed remove support for unprefixed @keyframes at version 15. Chrome unprefixed @keyframes in version 43, which suggests that Opera unprefixed in version 30 (i.e., Chrome version number - 13). This is corroborated by the Chrome Platform Status entry.

Instead, I think we need to restructure the Opera data with support statements in this order:

  1. (first position) A new entry with only "version_added": "30"
  2. Move the -webkit- data to this position
  3. Revert the changes you made to the 12.1 to 15 data
  4. (last position) The existing -o- prefix data

Also, while we're at it, it would be nice to see the indentation fixed to align with the other data in this file (the "opera" line seems to have started the misalignment). This isn't from your change, just an existing quirk.

I realize this feedback is a bit bigger than you probably had in mind, @antross! If you're keen to push a new commit or two to make these changes, I think it would be a big help! Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this feedback is a bit bigger than you probably had in mind, @antross! If you're keen to push a new commit or two to make these changes, I think it would be a big help!

Absolutely happy to make the additional changes here and thanks @ddbeck for the detailed explanation! I'll try to update the PR later today.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, while we're at it, it would be nice to see the indentation fixed to align with the other data in this file (the "opera" line seems to have started the misalignment). This isn't from your change, just an existing quirk.

@ddbeck I'm not sure I see the misalignment you referred to. The data immediately prior to "opera" for "ie" is at a slightly different indent, but that's because it's composed of a single version entry as opposed to an array containing multiple entries.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antross Sorry, I looked at the actual file on my machine and the indentation is fine. I think it was a quirk of how GitHub shows the expanded context. My mistake!

screen shot 2018-12-21 at 1 52 06 pm

},
{
"prefix": "-webkit-",
Expand Down