Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version inconsistencies in api/* (N through S) #3403

Merged

Conversation

queengooborg
Copy link
Collaborator

Sub-PR of #3368 for the fixes of the files themselves.

@Elchi3 Elchi3 added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 7, 2019
api/PaymentRequest.json Outdated Show resolved Hide resolved
api/PictureInPicture.json Outdated Show resolved Hide resolved
api/RTCPeerConnection.json Outdated Show resolved Hide resolved
api/RTCRtpReceiver.json Outdated Show resolved Hide resolved
api/Request.json Outdated Show resolved Hide resolved
api/SVGAnimationElement.json Outdated Show resolved Hide resolved
api/ShadowRoot.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@jpmedley jpmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is just one little issue, which I think is my fault for nat catching it before.

api/RTCPeerConnection.json Show resolved Hide resolved
@jpmedley
Copy link
Collaborator

jpmedley commented Feb 8, 2019

I've never heard of anyone at Google ever touching it. I certainly don't.

@queengooborg
Copy link
Collaborator Author

Review? @Elchi3 @ddbeck

@ddbeck ddbeck self-requested a review March 11, 2019 13:15
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright this was a big one! I've caught a small number of issues, but otherwise this looks pretty good. Thank you!

api/PictureInPicture.json Outdated Show resolved Hide resolved
api/Request.json Outdated Show resolved Hide resolved
api/Request.json Show resolved Hide resolved
api/ShadowRoot.json Outdated Show resolved Hide resolved
@queengooborg queengooborg force-pushed the linter/lint-version-consistency-apply/api-n-s branch from 828ca03 to 3b751c8 Compare March 12, 2019 17:16
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you! 🎉

@ddbeck ddbeck merged commit 0915061 into mdn:master Mar 13, 2019
@queengooborg
Copy link
Collaborator Author

💜

@queengooborg queengooborg deleted the linter/lint-version-consistency-apply/api-n-s branch March 13, 2019 13:03
wbamberg pushed a commit that referenced this pull request Mar 16, 2019
…vents

* upstream/master: (33 commits)
  Add data for RTCIceCandidatePairStats (#3628)
  Reference crbug for "bookmark" context type in extensions API (#3643)
  Fix incomplete Request constructor notes (#3629)
  71st alpha version
  Add animation support for grid-template properties (#3572)
  Add load and unload events (#3639)
  Update: Fullscreen API only works on iPad iOS (#3633)
  Add data for TextEncoder.encodeInto() method (#3581)
  Update Chrome 73 release date (#3620)
  Add beforeprint_event (#3637)
  Add BCD for animation and transition events (#3563)
  Add data for composition events (#3594)
  Add afterprint and beforeprint events (#3632)
  Add cut, copy, paste events (#3634)
  Add TransitionEvent.propertyName support to Chromium et al (#3525)
  Add Chrome support for Object.fromEntries (#3627)
  Added HTMLMediaElement Events (#3564)
  Fix version inconsistencies in api/* (T through Z) (#3404)
  Add Edge support for -ms-input- prefix for ::placeholder (#3605)
  Fix version inconsistencies in api/* (N through S) (#3403)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants