test: Add support for Node < 6 #3442
Conversation
| @@ -1,6 +1,6 @@ | |||
| 'use strict'; | |||
| const path = require('path'); | |||
| const {browsers} = require('..'); | |||
| const browsers = require('..').browsers; | |||
There was a problem hiding this comment.
The fact that this depends on the whole package also causes a syntax error in non‑browser files to cause the tests to fail with an unhelpful error message (see #2330).
Elchi3
added
infra 🏗️
|
Should we change anything to support Node versions before 6? All of the Node releases <6 have already reached end of life and Node 6 is EOL in a little less than two months (source) |
|
Well, it should still improve performance in modern Node given that this will stop depending on object destructuring to import test functions into the linter. Adding syntactic support for Node < 6 is just a nice bonus. |
|
OK, since there's a justification apart from supporting older Node versions, this works for me. I'm going to request Florian's review though because I think infra changes deserve a second or third look, depending on how you count. |
|
Can we get this merged? |
|
Yes, as this is not actually changing the minimum node version. I'll leave my questions unanswered then. |
|
I think the version should be answered in an issue first (#3509). |
Node < 6 doesn’t support destructuring.
This updates the tests (and other code) to not use it, thus removing the reason why #3428 was set to
>= 6.0.0