Rename contextMenus -> menus

[wbamberg]

Bug 1333403 introduced browser.menus as a replacement for browser.contextMenus, keeping contextMenus as an alias but recommending menus as the preferred form.

Chrome, Opera, and Edge only support contextMenus at this time. So, I've tried to handle this by:

• renaming the contextMenus node in the data to menus
• adding alternative_name for Chrome, Opera, and Edge, indicating that these APIs are available under contextMenus for those browsers
• adding a note for the Firefox data, indicating that that these APIs are also available under contextMenus for Firefox.

I also need to move menus to keep things alphabetical. But that makes the diff really hard to read. So I'v made the change in 2 commits:

• this commit: 73c00b3 is the one that actually changes the data, but doesn't move menus, so should be readable

• this commit: eb1b584 only moves menus, and doesn't change the data at all.

[wbamberg]

Sorry about the commit messages. They were supposed to be things like "Rename `contextMenus`" but I guess git commit -m swallows backticks :(.

[Rob--W]

but I guess git commit -m swallows backticks :(.

No, the shell swallows backticks (and executes whatever is in between as code!).

You can either use git commit and then write the commit message in an editor, or use single quotes instead of double quotes:

git commit -m 'Rename `contextMenus`'

Or, if you really want to use double quotes, put slashes before the backtick:

git commit -m "Rename \`contextMenus\`"

Now you've made the commits, it is possible to use interactive rebase with git rebase -i HEAD^^ and then use reword to change the commit message.

[Elchi3]

Thanks for splitting this change in 2 commits. Really helpful for reviewing! I'm sorry for my slowness in getting to this.

I think instead of the notes for Firefox, I would have put the information like this:

"firefox": [
  {
    "version_added": "55"
  },
  {
    "alternative_name": "contextMenus.ACTION_MENU_TOP_LEVEL_LIMIT",
    "version_added": "48"
  }
],

The menu API namespace isn't actually usable before 55 and we need that information displayed, right?

[wbamberg]

Let's try this again: #378.