[Chrome]Additions to #3994. #4011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queengooborg
added
the
data:api 🐇
|
Looking great! Can we also set values for Opera and Opera Android for completion? |
chrisdavidmills
requested changes
Apr 29, 2019
There was a problem hiding this comment.
Looks good to me, but I think @vinyldarkscratch has a point — if Chrome is false for onpayerdetailchange, then surely Opera must be as well? Can you update those values, then I'll merge? Thanks @jpmedley .
|
PTAL |
chrisdavidmills
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to #3994:
payerdetailchange/`onpayerdetailchange are not yet available in Chrome.conect/onconnectwas comited a month before Chrome 1 shipped