Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding data for straggler events #3994

Merged
merged 1 commit into from
Apr 25, 2019
Merged

adding data for straggler events #3994

merged 1 commit into from
Apr 25, 2019

Conversation

chrisdavidmills
Copy link
Collaborator

As per mdn/sprints#1318

Some of these were difficult to find much about. An explanation of each follows:

  • api.HTMLDetails​Element.toggle_event — this has no associated ontoggle property to copy off, so I ended up just copying the data for the HTMLDetailsElement as a whole. I did some local testing on macOS, and the event seemed to work in all the places I tested.
  • api.PaymentResponse.payerdetailchange_event — this had an old-style compat table left over in the event page, so I used that data (the old style table is still there, hidden using <div class=hidden></div>), also copying the data over to onpayerdetailchange and creating that data point too.
  • api.SharedWorkerGlobalScope.connect_event — easy; I just copied this from the available onconnect data
  • api.Window.clipboardchange — this is a very new event. There is no equivalent onclipboardchange handler specified at present, afaict, and it doesn't seem to work anywhere (I tested it in Chrome/Fx/Safari/Opera). So I put all the data as false.
  • api.HTMLElement.beforeinput_event — this is also very new, and does not appear to have an equivalent on... handler property. I tested it, and it didn't work in Firefox, but did in Chrome/Safari/Opera, so I have filled those in as true and guessed a bit at the mobile equivalents.

@chrisdavidmills
Copy link
Collaborator Author

@Elchi3 another one for the events ref to try and fit in the release ;-)

@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Apr 25, 2019
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks for the detailed explanations.
We can always improve this data as follow-ups, if needed.

https://developer.mozilla.org/en-US/docs/Web/API/PaymentResponse/payerdetail_event is at the wrong location, but you have the mdn_url correct in this PR, so I will merge this, but please move the mdn page.

@Elchi3 Elchi3 merged commit 3aa41a9 into mdn:master Apr 25, 2019
@chrisdavidmills
Copy link
Collaborator Author

https://developer.mozilla.org/en-US/docs/Web/API/PaymentResponse/payerdetail_event is at the wrong location, but you have the mdn_url correct in this PR, so I will merge this, but please move the mdn page.

Ooops! I've moved it now. Thanks so much for the quick turnaround on this.

@chrisdavidmills chrisdavidmills deleted the straggler-events branch April 29, 2019 08:34
chrisdavidmills pushed a commit that referenced this pull request Apr 29, 2019
* [Chrome]Additions to #3994.

* Change some Opera values to false.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants