Add Promise.allSettled() #4385
Add Promise.allSettled() #4385
Conversation
This patch adds this method to the Promise.json data with what should be correct version information for Chrome, Edge, and Firefox. There is no specification URL because currently `allSettled()` is not yet part of the spec, and the schema rejects the URL of the proposal. Sources: * https://tc39.es/proposal-promise-allSettled/ * Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1539694 * Chrome status: https://www.chromestatus.com/features/5547381053456384 * Edge: https://developer.microsoft.com/en-us/microsoft-edge/platform/catalog/?page=1&q=allSettled
a2sheppy
changed the title
|
Don't merge this. Turns out it's Nightly-only for now. |
queengooborg
added
data:js 📟
|
I know we’ve added features and set their notes as “Available only in nightly builds” before. Perhaps we could also do the same here? |
|
@vinyldarkscratch what to do about channel-gated features is a long-standing issue: #338. Personally, I've always seen the nightly notes a hack around the lack of consensus on the channel schema question. I agree with not merging this until the feature is actually headed to a release version of the browser |
There was a problem hiding this comment.
We should just set it to false for Firefox for now. We have this documented, so it needs a compat table, so this data should land. For the Nightly case, I think it makes no sense if it will be nightly only for just one release to have it in the data. I wouldn't bother with it in this case.
Generally, I agree with Daniel, the most interesting data is what is shipping to real users and so much like the compile flag cases, my feeling is that Nightly only data is not very useful. We should study this some more and clean the data if necessary in the issue linked from here.
We're also missing a spec_url. Please add it.
javascript/builtins/Promise.json
Outdated
| "version_added": false | ||
| }, | ||
| "firefox": { | ||
| "version_added": "68" |
There was a problem hiding this comment.
| "version_added": "68" | |
| "version_added": false |
javascript/builtins/Promise.json
Outdated
| "version_added": "68" | ||
| }, | ||
| "firefox_android": { | ||
| "version_added": "68" |
There was a problem hiding this comment.
| "version_added": "68" | |
| "version_added": false |
Elchi3
changed the title
Elchi3
removed
the
not ready ⛔
Sorry, didn't see this in my review (the review button is there when you look at the diff and you don't see the thread then, bugs me for longer with GitHub already). Try this URL that has a deep link which spec_url requires: https://tc39.es/proposal-promise-allSettled/#sec-promise.allsettled (I just noticed we only have |
Set Firefox to `false` and added a `spec_url` entry referencing the proposal. This will need to be updated when `allSettled()` is added to the spec proper.
This patch adds this method to the Promise.json data with what should be
correct version information for Chrome, Edge, and Firefox. There is no
specification URL because currently
allSettled()is not yet part of thespec, and the schema rejects the URL of the proposal.
Sources: