Update mouse events #4524
Merged
Update mouse events #4524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the code in my fork
Merge latest MDN changes into my repository
Update my fork from original
Update fork to match mdn repo
23 tasks
a2sheppy
approved these changes
Jul 22, 2019
Elchi3
added
the
data:api 🐇
jpmedley
requested changes
Jul 24, 2019
api/Element.json
Outdated
| "version_added": false | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": true |
There was a problem hiding this comment.
This should definitely be fixed before this PR is merged.
| "version_added": true | ||
| }, | ||
| "safari_ios": { | ||
| "version_added": true |
There was a problem hiding this comment.
"webview_android" is missing from this and several others. It should match "chrome" (at least for this API). Please add it throughout.
There was a problem hiding this comment.
IMO this should be done in a follow-up PR.
There was a problem hiding this comment.
I have made the update and pushed it.
|
Joe has approved, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Sheppy's comments in MDN/Sprints #955, I've updated the BCD for mouse events to include missing information.