Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update status for CSS Scroll Snapping properties #609

Merged
merged 4 commits into from
Nov 8, 2017
Merged

Update status for CSS Scroll Snapping properties #609

merged 4 commits into from
Nov 8, 2017

Conversation

myakura
Copy link
Contributor

@myakura myakura commented Nov 7, 2017

this patch updates CSS Scroll Snapping properties with the following changes:

  • corrects the name of the flag to enable the property
  • update support status on Firefox for Android
  • fixing errors and adding missing entries for Edge(s)

the flag name was noted as "layout.css.vertical-text.enabled", which was for css writing modes.
update it to the correct flag "layout.css.scroll-snap.enabled" per https://hg.mozilla.org/integration/mozilla-inbound/rev/6fb93b485e4c
although it's deprecated, other deprecated scroll-snap properties have edges in the json.
It was Firefox for Android that required the flag.
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+

@teoli2003 teoli2003 merged commit 3dd4077 into mdn:master Nov 8, 2017
@teoli2003 teoli2003 added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants