New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inspector gives incorrect Mozilla docs link for ScrollLinkedEffects performance #1533
Comments
Thanks for reporting this @Scrabble96! So, to whoever fixes this, I'd say that this requires one definite immediate action — to add a line to https://github.com/mdn/content/blob/main/files/en-us/_redirects.txt to redirect https://developer.mozilla.org/en-US/docs/Mozilla/Performance/ScrollLinkedEffects to https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Scroll-linked_effects And a stretch goal would be to figure out how to update the URL in the Firefox source code to the correct one, so that the redirect is no longer needed. |
I digged the source code of Firefox. Here you go: https://hg.mozilla.org/mozilla-central/file/tip/dom/locales/en-US/chrome/layout/layout_errors.properties#l12 Last time touched by @staktrace in 2016 to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1245245 |
@chrisdavidmills I fixed the link in _redirects - #1590. Leaving the URL update in Firefox for someone else :-) |
Thanks @hamishwillee ! If anybody wants to make to change in Firefox I'm happy to guide them. If not I can do it. |
@hamishwillee and @chrisdavidmills |
@Aayushap1 The change Kartikaya mentioned would be done for Firefox, which is tracked in Mercurial. Please get in touch with @staktrace if you want to contribute there. |
The redirect means that the link is not broken anymore, so I'm going to close this one. |
The redirect doesn't seem to work anymore - https://developer.mozilla.org/docs/Mozilla/Performance/ScrollLinkedEffects still goes to a 404 |
We got a report about this in Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1723761, should we open a new bug for this? |
@chrisdavidmills is there a way to stop this page from getting moved and/or archived? Or a way to get a permalink to the content that will remain valid? If not maybe we should just move that content off MDN. |
I have no idea what MDN policy is, but IMO "necrobumping" issues is always a bad idea. In particular, @chrisdavidmills no longer works for MDN, so will not necessarily be able to see this. @nchevobbe and @staktrace For now lets follow this on the duplicate open issue #1532 |
@Scrabble96 commented on Wed Jan 20 2021
Request type
Details
I use a JavaScript file to create a 'back to top' icon and function when visitors scroll beyond 350px. In the Firefox (84.0.2 64-bit) Console there was, unsurprisingly, a message about this:
"This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://developer.mozilla.org/docs/Mozilla/Performance/ScrollLinkedEffects for further details and to join the discussion on related tools and features!"
However, if you go to that URL - https://developer.mozilla.org/docs/Mozilla/Performance/ScrollLinkedEffects - you get a 404 error. The correct URL is https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Scroll-linked_effects
The text was updated successfully, but these errors were encountered: