Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke previously defined command instead of running node directly #17643

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

Josh-Cena
Copy link
Member

Summary

Fix #10972; supersedes #17642

Motivation

It's generally recommended to avoid running node, especially when using Yarn PnP since it simply doesn't work. For any slightly non-trivial task, including starting a server, abstraction with a custom command is recommended, and since we already have a command, let's use it instead.

Supporting details

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@Josh-Cena Josh-Cena requested a review from a team as a code owner June 25, 2022 09:45
@Josh-Cena Josh-Cena requested review from wbamberg and removed request for a team June 25, 2022 09:45
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jun 25, 2022
@Josh-Cena
Copy link
Member Author

Also, the problem with having this kind of tutorial on MDN is that the web dev stack and practices renovate almost every six months, so it's super hard to keep the content up to date...

Copy link
Collaborator

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Beautiful — thanks much

@sideshowbarker sideshowbarker merged commit 4adba2c into mdn:main Jun 25, 2022
@Josh-Cena Josh-Cena deleted the fix-command branch June 25, 2022 11:09
@sideshowbarker
Copy link
Collaborator

Also, the problem with having this kind of tutorial on MDN is that the web dev stack and practices renovate almost every six months, so it's super hard to keep the content up to date...

Very true — and unfortunately that problem isn’t unique to this particular article; especially in the Learn subtree, we’ve got a number of guides which just inherently have a pretty short shelf life built in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with "Setup": Yarn 2.0 won't create the node_modules directory.
2 participants